Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VA-16921] Add Prepare for Visit to VBA Facility Page #1904

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

maxx1128
Copy link
Contributor

@maxx1128 maxx1128 commented Feb 7, 2024

Summary

The VBA Regional Facilities pages have a "Prepare for your Visit" section but no content. This pull request shows that information on the page. If there's no information for this section, it and its header aren't added to the page.

Related issue(s)

Testing done

Visual. See this regional facility page on my tugboat that, as of this writing, has an example of the displayed data.

Screenshots

Screen Shot 2024-02-07 at 3 14 09 PM

What areas of the site does it impact?

All regional facilities pages (not currently published)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • A Screenshot of the developed feature is added
  • Design review has been performed
  • Accessibility testing has been performed

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/va-16921-vba-prepare-for-visit February 7, 2024 17:09 Inactive
@maxx1128 maxx1128 force-pushed the va-16921-vba-prepare-for-visit branch from 240d29e to 668dcba Compare February 7, 2024 18:06
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/va-16921-vba-prepare-for-visit February 7, 2024 18:42 Inactive
@maxx1128 maxx1128 force-pushed the va-16921-vba-prepare-for-visit branch from 668dcba to 5a9df34 Compare February 7, 2024 19:22
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/va-16921-vba-prepare-for-visit February 7, 2024 19:28 Inactive
Copy link
Contributor

@eselkin eselkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chriskim2311 chriskim2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maxx1128 maxx1128 merged commit bb1e025 into main Feb 13, 2024
25 checks passed
@maxx1128 maxx1128 deleted the va-16921-vba-prepare-for-visit branch February 13, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants