Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP Error when saving Featured Event nodes #16882

Closed
1 task
Tracked by #16828
dsasser opened this issue Jan 17, 2024 · 2 comments
Closed
1 task
Tracked by #16828

PHP Error when saving Featured Event nodes #16882

dsasser opened this issue Jan 17, 2024 · 2 comments
Assignees
@dsasser
Labels
Defect Something isn't working (issue type) Drupal engineering CMS team practice area Public Websites Scrum team in the Sitewide crew sitewide

Comments

@dsasser
Copy link
Contributor

dsasser commented Jan 17, 2024 •
edited by jilladams
Loading

Description

Error: Call to a member function getValue() on null in Drupal\va_gov_content_types\Entity\Event->addToNationalOutreachCalendar()

When saving some nodes (eg: node/64741/edit), an error is thrown:

Error: Call to a member function getValue() on null in Drupal\va_gov_content_types\Entity\Event->addToNationalOutreachCalendar()

Originally reported via Slack.

Engineering notes / background

It appears in some cases the field field_publish_to_outreach_cal has no value, and so calling first() on null is returning the error.

Acceptance criteria

  • Error is no longer thrown on node 64741 (or similar nodes without a field_publish_to_outreach_cal value).
@dsasser dsasser added Drupal engineering CMS team practice area Needs refining Issue status Public Websites Scrum team in the Sitewide crew labels Jan 17, 2024
@dsasser dsasser self-assigned this Jan 17, 2024
@jilladams jilladams added the Defect Something isn't working (issue type) label Jan 17, 2024
@jilladams jilladams mentioned this issue Jan 17, 2024
Closed
24 tasks
@jilladams
Copy link
Contributor

Slack thread with original report / risk assessment for why we should prioritize now: https://dsva.slack.com/archives/CJT90C0UT/p1705501739844599

@jilladams jilladams removed the Needs refining Issue status label Jan 17, 2024
@dsasser dsasser mentioned this issue Jan 18, 2024
Merged
13 tasks
@dsasser
Copy link
Contributor Author

dsasser commented Jan 24, 2024

Verified on Prod:

Screenshot 2024-01-24 at 8 06 18 AM

@dsasser dsasser closed this as completed Jan 24, 2024
@jilladams jilladams changed the title Error: Call to a member function getValue() on null in Drupal\va_gov_content_types\Entity\Event->addToNationalOutreachCalendar() PHP Error when saving Event nodes Jan 26, 2024
@dsasser dsasser changed the title PHP Error when saving Event nodes PHP Error when saving Featured Event nodes Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsasser dsasser

Labels
Defect Something isn't working (issue type) Drupal engineering CMS team practice area Public Websites Scrum team in the Sitewide crew sitewide
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsasser @jilladams