Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot create new Reusable Q&A nodes #16108

Closed
3 of 7 tasks
Tracked by #16112
laflannery opened this issue Nov 13, 2023 · 3 comments
Closed
3 of 7 tasks
Tracked by #16112

Cannot create new Reusable Q&A nodes #16108

laflannery opened this issue Nov 13, 2023 · 3 comments
Assignees
Labels
Defect Something isn't working (issue type) Drupal engineering CMS team practice area Public Websites Scrum team in the Sitewide crew Q&A CMS managed product co-owned by Facilities & Public Websites teams sitewide

Comments

@laflannery
Copy link
Contributor

laflannery commented Nov 13, 2023

Describe the defect

When trying to create a new node from the Reusable Q&A content type, I am not able to because it is validating on conditional fields.

When creating a Reusable Q&A, there is an option to "Enable standalone Resources and support page for this Q&A." If selected, this adds many more additional fields that the editor can fill out, including some required fields. Unfortunately, these fields are being validated on even if I haven't checked this option.

Examples

First time I try to create a Reusable Q&A, I filled out the Question, Answer and the Revision log message. Upon trying to save this node, I get a validation that this can't be saved because 2 fields have an error:

  • Section - accurate, I did purposely not fill this out, it's a field over in the right column
  • Link - not accurate, this is a field that is within the conditional additional fields

Screenshot of content I filled out and error
image
Screenshot of where the link field is (which shows AFTER I select the checkbox)
image

To Reproduce

Steps to reproduce the behavior:

  1. Create a new reusable Q&A on staging
  2. Fill out all required fields
  3. Scroll down and attempt to save the new node
  4. See validation error

AC / Expected behavior

  • Write a test that will catch this scenario
  • Fields should only be validated on if they are being used

Additional context

I also was getting additional validation errors on other fields when I changed the conditional content. For example:

  1. I opened the standalone content options
  2. Changed "Contact Information" to be "Benefit Hubs Contacts"
  3. Didn't select any contacts
  4. Unselected the Standalone contact option (so the additional fields are gone now)
  5. Tried to save my Q&A and this time got a validation message for Link AND Benefits Hub Contacts

Team

Please check the team(s) that will do this work.

  • CMS Team
  • Public Websites
  • Facilities
  • User support
  • Accelerated Publishing
@laflannery laflannery added Defect Something isn't working (issue type) Needs refining Issue status labels Nov 13, 2023
@github-actions github-actions bot added the Public Websites Scrum team in the Sitewide crew label Nov 13, 2023
@jilladams jilladams added the Q&A CMS managed product co-owned by Facilities & Public Websites teams label Nov 13, 2023
@jilladams
Copy link
Contributor

This is happening in prod / staging as well, so not limited to D10. Good find, Laura.

@FranECross
Copy link

Timeboxing to determine cause and then revisit if it's time consuming to fix.

@jilladams
Copy link
Contributor

Verified on Staging, which is downstream from Prod and therefore verifies prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Something isn't working (issue type) Drupal engineering CMS team practice area Public Websites Scrum team in the Sitewide crew Q&A CMS managed product co-owned by Facilities & Public Websites teams sitewide
Projects
None yet
Development

No branches or pull requests

4 participants