Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Update Beneficiary Tag logic to accommodate multi-select #16099

Closed
3 tasks
Tracked by #16112
randimays opened this issue Nov 13, 2023 · 4 comments
Closed
3 tasks
Tracked by #16112

FE: Update Beneficiary Tag logic to accommodate multi-select #16099

randimays opened this issue Nov 13, 2023 · 4 comments
Assignees
Labels
Public Websites Scrum team in the Sitewide crew Resources and support CMS managed product owned by Public Websites team sitewide VA.gov frontend CMS team practice area

Comments

@randimays
Copy link
Contributor

randimays commented Nov 13, 2023

Description

In support of #13188, update the FE templates and logic in content-build so Beneficiary Tags support a multi-select rather than a radio button.

Current implementation (radio button)
image

See https://www.va.gov/resources/will-i-have-to-pay-back-the-gi-bill-benefits-i-used-if-i-fail-a-class/ for example of Tag usage in production.

Refer to this comment for an overview of what FE content-build files are affected / what changes need to be made. There are also instructions on how to validate everything in the Tugboat instance for these changes.

Quality / testing notes

All of these CMS content types / nodes need to be validated for correct functionality. See this comment for instructions on how to add each one to a Tugboat to test with your WIP branch.

  • checklist
  • media_list_images
  • media_list_videos
  • step_by_step
  • faq_multiple_q_a
  • q_a
  • support_resources_detail_page

We also need to update relevant unit test(s):

  • liquid.unit.spec.js after changes to getTagsList utility
  • If possible, add tests for create-resources-and-support-section.js's groupByTags utility

Acceptance criteria

  • For all 6 affected content types: all Beneficiaries checked for a particular article appropriately display as tags on that article and link to tag pages
  • Unit tests are updated
  • README is updated
@randimays randimays added Needs refining Issue status Public Websites Scrum team in the Sitewide crew VA.gov frontend CMS team practice area labels Nov 13, 2023
@jilladams jilladams added the Resources and support CMS managed product owned by Public Websites team label Nov 13, 2023
@FranECross
Copy link

@jilladams @chriskim2311 I added AC to this story (as discussed in refinement today). Please review when you can and let me know if anything seems amiss/is missing/needs to change. Thanks in advance!

@FranECross FranECross removed the Needs refining Issue status label Nov 15, 2023
@jilladams
Copy link
Contributor

@FranECross made a couple edits:

  • Relocated the ACs re: the CMS UX (checkboxes vs. radio buttons) and the KB article into the backend ticket, R&S Editor UX allows multiple Beneficiaries per article #13188
  • Added a note to the "Beneficiaries checked for a particular article appropriately display" AC to indicate that Tags should link through to Tag pages. (That's true in Prod where they appear today, and we just don't wanna regress it / should do that for new tags appearing.)
  • I didn't modify the README AC but I'm not sure which README is in mind - possible to add a link to that, so Eng knows what needs the update?

@chriskim2311
Copy link
Contributor

Just pulled this in on Monday. Will carry over into next sprint.

@jilladams
Copy link
Contributor

Deployed. Closing. CAIA will need to verify in Prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Public Websites Scrum team in the Sitewide crew Resources and support CMS managed product owned by Public Websites team sitewide VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

4 participants