Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Drupal View of System Ids and Connected Facility Ids into KISS format #16019

Closed
6 of 10 tasks
eselkin opened this issue Nov 6, 2023 · 6 comments
Closed
6 of 10 tasks
Assignees
Labels
Facilities Facilities products (VAMC, Vet Center, etc) sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team

Comments

@eselkin
Copy link
Contributor

eselkin commented Nov 6, 2023

User Story or Problem Statement

We need to get the facilities and system ids / system names / facility names from drupal view into content-build as a JSON file for KISS structure.

Description or Additional Context

This view's data will be used by VA Police and possibly other data.

Will require two PRs.

Acceptance Criteria

  • CSV is pulled from prod CMS
  • vamc-system.json is created in cache static data files
  • e2e testing is added that vamc-system.json is created
  • Selector is created in vets-website
  • Connector is creates in vets-website
  • Accelerated Publishing FE folks are added as code reviewers on the PR (Ryan Koch)

Team

Please check the team(s) that will do this work.

  • CMS Team
  • Public Websites
  • Facilities
  • Accelerated Publishing
@eselkin eselkin added Needs refining Issue status VA.gov frontend CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) VAMC CMS managed product owned by Facilities team labels Nov 6, 2023
@eselkin
Copy link
Contributor Author

eselkin commented Nov 14, 2023

I think this needs to be blocked by a Drupal ticket of getting this view created.

@xiongjaneg
Copy link
Contributor

xiongjaneg commented Nov 15, 2023

@xiongjaneg added dependency on #16015

@xiongjaneg xiongjaneg removed the Needs refining Issue status label Nov 15, 2023
@eselkin eselkin self-assigned this Dec 5, 2023
@eselkin
Copy link
Contributor Author

eselkin commented Dec 6, 2023

Created branch VAMC-16019-KISS-VAMC-system-facilities-list
Yes, It should have been VACMS-1... but I typoed and pushed
This branch pulls from staging.cms.va.gov for the CSV currently.
Need to wait for merging change to testing from the JSON testing branch for VA Police testing

@xiongjaneg
Copy link
Contributor

@jilladams I'm not going to carry this over to 101 since we've decided to prioritize VBA and the FL spike for now. This one can park in Ready until the rest of police are ready to go once we get the police data the way we need it.

@jilladams
Copy link
Contributor

@ryguyk @timcosgrove FYI that we are planning this KISS-related ticket to sprint starting today. Current thinking: we plan to implement in not-AP, as we will likely head to prod before AP's prod timing. We can track the migration to the AP version of KISS later, but will add Ryan as code reviewer for this work as FYI. Let us know if that makes sense to y'all or not.

@jilladams
Copy link
Contributor

The last AC here was to put Ryan Koch on PRs as reviewer, which we overlooked at PR time. Started a Slack thread here for his reference: https://dsva.slack.com/archives/C0FQSS30V/p1706301411453809

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc) sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

3 participants