Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate PHPStan baseline. #15953

Closed
1 task done
ndouglas opened this issue Nov 1, 2023 · 1 comment · Fixed by #16104
Closed
1 task done

Regenerate PHPStan baseline. #15953

ndouglas opened this issue Nov 1, 2023 · 1 comment · Fixed by #16104
Assignees
@JunTaoLuo
Labels
CMS Team CMS Product team that manages both editor exp and devops Needs refining Issue status Quality Assurance

Comments

@ndouglas
Copy link
Contributor

ndouglas commented Nov 1, 2023 •
edited by JunTaoLuo
Loading

Description

@JunTaoLuo encountered errors running PHPStan locally; these should be added to the baseline.

Acceptance Criteria

  • New baseline includes all existing errors so that running composer va:test:phpstan only lists new errors.
@ndouglas ndouglas added Needs refining Issue status CMS Team CMS Product team that manages both editor exp and devops Quality Assurance labels Nov 1, 2023
@JunTaoLuo
Copy link
Contributor

cc @BerniXiongA6, this should be a small/quick task.

@BerniXiongA6 BerniXiongA6 mentioned this issue Nov 9, 2023
Closed
63 tasks
@JunTaoLuo JunTaoLuo mentioned this issue Nov 13, 2023
Merged
13 tasks
@JunTaoLuo JunTaoLuo self-assigned this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JunTaoLuo JunTaoLuo

Labels
CMS Team CMS Product team that manages both editor exp and devops Needs refining Issue status Quality Assurance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

VACMS-15953 Regenerate phpstan baselines department-of-veterans-affairs/va.gov-cms
2 participants
@ndouglas @JunTaoLuo