Nest <va-promo-banner> within <header>

[laflannery]

Description

The <va-promo-banner> should be nested under the <header> This currently isn't being flagged as an error because it has it's own landmark role being applied to it. However, this shouldn't be there and I've asked that it be removed. I would like to move this under the <header> during the redesign because that's where it should be to ensure all content is contained by a landmark.

Steps for Implementation

Move the <va-promo-banner> directly underneath the <div id="legacy-header">:

I think this is ok for the injected header too because just the Legacy Header gets injected from what I was seeing but obviously this needs to be confirmed

Acceptance Criteria

• The <va-promo-banner> is wrapped within the <header>
• The injected header is not impacted
• Requires design review
• Requires accessibility review

Team

Please check the team(s) that will do this work.

• CMS Team
• Public Websites
• Facilities
• Accelerated Publishing

[jilladams]

Noting: from Laura's perspective, this isn't hugely critical, just nice to fix early if we can. If we determine that the testing burden is high and should wait til we implement the Federal header / footer, that's ok.

[chriskim2311]

@laflannery Can you take a quick look at this before I close. I was able to see the correct html markup for the va-promo-banner.

[laflannery]

Looks good @chriskim2311 - It is correctly under the Header (aka banner landmark) and no additional axe errors because the DST update shipped too, gold stars for everyone!!

[chriskim2311]

Great thanks for taking a look closing!