VACMS 15943: Move promo banner into header tag #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chriskim2311 This is exactly what I wanted, and I just want to note that this is going to create 3 new axe errors (1, 2 & 4 in this screenshot). These will be resolved as soon as this DST ticket is released though: |
|
This looks good to me! |
|
Thanks for the quick reviews! Will merge once I get a code review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moves promo banner under the header. Checked and this will not impact injected header.
Related issue(s)
department-of-veterans-affairs/va.gov-cms#15943
Testing done
Tested the header markup to make sure the promo banner element is inside the header tag
What areas of the site does it impact?
Header
Acceptance criteria
<va-promo-banner>is wrapped within the<header>