Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish and enact VBA facility alias pattern #15155

Closed
2 tasks
Tracked by #16268
swirtSJW opened this issue Sep 8, 2023 · 8 comments
Closed
2 tasks
Tracked by #16268

Establish and enact VBA facility alias pattern #15155

swirtSJW opened this issue Sep 8, 2023 · 8 comments
Assignees
Labels
CY24-Q2 Calendar year Q2 2024 priority Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) IA Information Architecture practice area Regional office CMS managed VBA product owned by the Facilities team sitewide VBA for VBA facilities that are not Regional Offices

Comments

@swirtSJW
Copy link
Contributor

swirtSJW commented Sep 8, 2023

@davidmpickett to refine this ticket based on outcomes of #15752

User Story or Problem Statement

Currently VBAs have a pattern of [node:field_administration:entity:name]/locations/[node:title]

We need to update this schema to follow the recommendations out of #15752 that are documented here: https://github.com/department-of-veterans-affairs/va.gov-team/tree/master/products/facilities/naming-schema#vba-benefits-facilities-naming-schema

BLOCKER: Need to confirm that #15752 (comment) comment has been addressed in documentation before we start work. Not a blocker for this ticket. This ticket will be scoped to just removing the Section/Location aspect of the URL so they are all [Node Title].

Acceptance Criteria

  • VBA facility path aliases match the naming schema
  • Validated in Tugboat
@swirtSJW swirtSJW added Facilities Facilities products (VAMC, Vet Center, etc) IA Information Architecture practice area Needs refining Issue status VBA for VBA facilities that are not Regional Offices labels Sep 8, 2023
@swirtSJW
Copy link
Contributor Author

swirtSJW commented Sep 8, 2023

Example of a really long path for a facility
/salt-lake-city-va-regional-benefit-office-at-george-e-wahlen-department-of-veterans-affairs-medical-center/locations/pre-discharge-site-at-fort

@davidmpickett
Copy link
Contributor

Per CAIA, namespacing request has been denied

@davidmpickett
Copy link
Contributor

I think this ticket has been rendered moot by #15752. Or at least we know what the alias pattern will be from that ticket.

@omahane @Becapa is there anything specific we'd need to do in Drupal to "enact" the alias pattern?

@davidmpickett
Copy link
Contributor

Closing as duplicate. #17351 will address the open question of how/where we cut the long names into condensed names. The condensed names will power H1/Breadcrumbs & URL

@davidmpickett davidmpickett closed this as not planned Won't fix, can't repro, duplicate, stale Feb 27, 2024
@davidmpickett davidmpickett reopened this Apr 3, 2024
@davidmpickett davidmpickett added the Drupal engineering CMS team practice area label Apr 3, 2024
@davidmpickett
Copy link
Contributor

Reopening this, because even without figuring out how we are snipping long names, the URL structure needs to be updated before staging review.

@davidmpickett davidmpickett added the Regional office CMS managed VBA product owned by the Facilities team label Apr 3, 2024
@jilladams jilladams removed the Needs refining Issue status label Apr 11, 2024
@jilladams
Copy link
Contributor

Right now: NCA / VBA use the same pattern. Split them, please

@omahane
Copy link
Contributor

omahane commented Apr 29, 2024

@jilladams @davidmpickett I'm going to check prod. While we can't publish VBA or NCA for now, I can check the alias patterns and make sure they are as we expect.

@omahane
Copy link
Contributor

omahane commented Apr 30, 2024

VBA is now like Vet Center on Prod.
Screenshot 2024-04-30 at 07 27 40

And NCA is all by its lonesome.

@omahane omahane closed this as completed Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CY24-Q2 Calendar year Q2 2024 priority Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) IA Information Architecture practice area Regional office CMS managed VBA product owned by the Facilities team sitewide VBA for VBA facilities that are not Regional Offices
Projects
None yet
Development

No branches or pull requests

4 participants