Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit feature toggles for opportunities to retire #10350

Closed
2 of 10 tasks
dsinla opened this issue Aug 19, 2022 · 4 comments
Closed
2 of 10 tasks

Audit feature toggles for opportunities to retire #10350

dsinla opened this issue Aug 19, 2022 · 4 comments
Assignees
Labels
Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status sitewide

Comments

@dsinla
Copy link
Contributor

dsinla commented Aug 19, 2022

Description

Request from @RachalCassity:
Console Services Team is evaluating site performance, and identified feature toggles in vets-api and vets-website repos.
Feature toggles endpoint is called multiple times per page, and causes Sentry errors / site latency.

8 of the 12 feature toggles on this list explicitly identify facility_locator:

Feature Flag Name Added to vets-website Team Removed
enrollment_verification 6 months ago vsa-public-websites-frontend No
facilities_ppms_suppress_all 12 months ago vsa-public-websites-frontend No
facilities_ppms_suppress_community_care 9 months ago vsa-public-websites-frontend No
facilities_ppms_suppress_pharmacies 11 months ago vsa-public-websites-frontend No
facility_locator_lat_long_only 9 months ago vsa-public-websites-frontend No
facility_locator_lighthouse_covid_vaccine_query 11 months ago vsa-public-websites-frontend No
facility_locator_show_health_connect_number 8 months ago vsa-public-websites-frontend No
facility_locator_predictive_location_search 11 months ago vsa-public-websites-frontend No
facility_locator_rails_engine 11 months ago vsa-public-websites-frontend No
facility_locator_restore_community_care_pagination 9 months ago vsa-public-websites-frontend No
facility_locator_show_community_cares 11 months ago vsa-public-websites-frontend No
facility_locator_show_operational_hours_special_instructions 11 months ago vsa-public-websites-frontend No

Link to Slack convo
Related PW ticket

Acceptance Criteria

  • Audit the list of FE flipper toggles and confirm which if any are owned by Sitewide Facilities team
  • Audit the list of CMS based feature toggles and confirm which if any are owned by Sitewide Facilities team
  • Assess whether any / all can be removed, and summarize task steps & take a stab at effort

CMS Team

Please check the team(s) that will do this work.

  • Program
  • Platform CMS Team
  • Sitewide Crew
  • ⭐️ Sitewide CMS
  • ⭐️ Public Websites
  • ⭐️ Facilities
  • ⭐️ User support
@dsinla dsinla added the Needs refining Issue status label Aug 19, 2022
@github-actions github-actions bot added Facilities Facilities products (VAMC, Vet Center, etc) Public Websites Scrum team in the Sitewide crew labels Aug 19, 2022
@dsinla dsinla changed the title <Insert summary of task> Audit feature toggles for opportunities to retire Aug 19, 2022
@swirtSJW
Copy link
Contributor

swirtSJW commented Aug 24, 2022

This should be done on a joint call with PWS, Facilites and Dave Conlon as well as a CMS engineer and a FE engineer from both teams.

On the call, engineers will need to search all three code bases for each flag to determine if they are used anywhere and can be removed.|

Include audit of CMS internal toggles with this same team

@dsinla dsinla added the Drupal engineering CMS team practice area label Aug 29, 2022
@dsinla dsinla self-assigned this Aug 29, 2022
@jilladams jilladams removed the Public Websites Scrum team in the Sitewide crew label Aug 29, 2022
@dsinla
Copy link
Contributor Author

dsinla commented Aug 31, 2022

Meeting held today 08/30. @swirtSJW @jilladams who is doing the summarizing task steps and taking stab at effort?

@jilladams
Copy link
Contributor

@dsinla a Facilities front-end engineer will need to look through the list of Flippers owned by Facilities team, most likely.

@dsinla
Copy link
Contributor Author

dsinla commented Sep 8, 2022

Closing - audit completed. Executing will be done next sprint #10656

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status sitewide
Projects
None yet
Development

No branches or pull requests

3 participants