Skip to content

Commit

Permalink
Revert "Minimize PR overhead for non-code changes (#16279)"
Browse files Browse the repository at this point in the history
This reverts commit 176aa38.
  • Loading branch information
JunTaoLuo committed Feb 2, 2024
1 parent 75cef86 commit c7bb3bf
Show file tree
Hide file tree
Showing 8 changed files with 45 additions and 309 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/continuous_integration.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
name: Continuous Integration
on:
pull_request:
paths-ignore:
- '**.md'
on: [pull_request]
permissions:
pull-requests: write
issues: write
Expand Down
105 changes: 0 additions & 105 deletions .github/workflows/set-tests-statuses.yml

This file was deleted.

43 changes: 43 additions & 0 deletions .github/workflows/set-tugboat-tests-pending.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
name: Set Tugboat Tests Pending
on:
- pull_request_target
permissions:
pull-requests: write
checks: write
contents: write
statuses: write
jobs:
# Tugboat tests are not automatically set pending, even though they are
# required in branch protection rules (see #10553).
#
# Therefore, a PR can inappropriately appear to be ready to merge if,
# for instance, a composer.lock merge conflict prevents the Tugboat
# preview from successfully building.
#
# This action sets these tests pending from an immediate GitHub Action
# so that we can trust our automated code review processes more.
set-tugboat-tests-pending:
name: Set Tugboat Tests Pending
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- name: Set status for Tugboat tasks.
run: |
test_names=(
va/tests/cypress
va/tests/phpunit
va/tests/content-build-gql
va/tests/status-error
)
for test_name in "${test_names[@]}"; do
gh api \
--method POST \
-H "Accept: application/vnd.github+json" \
"/repos/${GITHUB_REPOSITORY}/statuses/${SHA}" \
-f state='pending' \
-f context="${test_name}";
done;
env:
SHA: ${{ github.event.pull_request.head.sha }}
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
39 changes: 0 additions & 39 deletions .github/workflows/tugboat-pr-closed.yml

This file was deleted.

47 changes: 0 additions & 47 deletions .github/workflows/tugboat-pr-opened.yml

This file was deleted.

39 changes: 0 additions & 39 deletions .github/workflows/tugboat-pr-updated.yml

This file was deleted.

74 changes: 0 additions & 74 deletions .github/workflows/tugboat-refresh-cache.yml

This file was deleted.

2 changes: 1 addition & 1 deletion tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ output: 'group'
tasks:

# Any changes to test names or additions or removals must be updated in
# .github/workflows/set-tests-statuses.yml as well for the
# .github/workflows/set-tugboat-tests-pending.yml as well for the
# test to be required effectively.

# The following is necessary to ensure that the tests are set to "pending"
Expand Down

0 comments on commit c7bb3bf

Please sign in to comment.