Skip to content

Commit

Permalink
Merge branch 'main' into dependabot/github_actions/cypress-io/github-…
Browse files Browse the repository at this point in the history
…action-6.7.1
  • Loading branch information
edmund-dunn authored Jul 30, 2024
2 parents e9a8c0a + a17a296 commit c15b810
Show file tree
Hide file tree
Showing 51 changed files with 1,449 additions and 1,116 deletions.
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/pw-clp-request.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
name: "(PW) Campaign Landing Page request"
name: "(Sitewide) Campaign Landing Page request"
about: Request a new Campaign Landing Page, owned by Public
Websites team
title: 'Campaign Landing Page request: <content info>'
Expand Down Expand Up @@ -40,8 +40,8 @@ Submitter: <insert_name>
- Request comes in, via helpdesk request or direct to PO, or potentially in a Github issue.
- [ ] If not in a helpdesk request, redirect to Helpdesk or create a Helpdesk issue using email [email protected] or URL https://prod.cms.va.gov/help
Helpdesk will use #sitewide-public-websites channel to request approvals
- [ ] In helpdesk ticket, @ mention Dave Conlon to review/approve the creation / existence / description of the CLP. Example text:
> Hi Dave, Helpdesk has received a request for a new Campaign Landing Page. Can you confirm that this CLP is approved?
- [ ] In helpdesk ticket, @ mention Michelle Middaugh to review/approve the creation / existence / description of the CLP. Example text:
> Hi Michelle, Helpdesk has received a request for a new Campaign Landing Page. Can you confirm that this CLP is approved?
### **If not approved**
- [ ] Close the Helpdesk ticket and the Github issue.
Expand Down
28 changes: 14 additions & 14 deletions .github/ISSUE_TEMPLATE/runbook-facility-url-change.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,45 +16,45 @@ When does this request need to be live:
(Note: This issue will be used from initial request through implementation to ensure all individuals working on this are notified of status updates. Please do not create multiple issues to track different steps.)
- [ ] Notify VA stakeholders as appropriate.
- [ ] Link the related facility closure / rename issue.
- [ ] Create a URL redirect in the [devops](https://github.com/department-of-veterans-affairs/devops) repo in `ansible/deployment/config/revproxy-vagov/vars/redirects.yml`
- [ ] Create a URL redirect in the [vsp-platform-revproxy](https://github.com/department-of-veterans-affairs/vsp-platform-revproxy) repo in `template-rendering/revproxy-vagov/vars/redirects.yml`
- [ ] Add the "Awaiting redirect" flag to the facility node with a revision log message that includes a link to this ticket, preserving the node's current moderation state.
- [ ] Redirects deploy daily except Friday at 10am ET, or by requesting OOB deploy (of the revproxy job to prod) in #vfs-platform-support. After deploy, validate that the URL redirect is deployed. (Note: In the event of a facility closure or a name change, validate that this occurs before making the Lighthouse csv changes.)
- [ ] Update this ticket with a comment that the redirect has been deployed.
- [ ] Remove the "Awaiting redirect" flag on the facility node with a revision log message that includes a link to this ticket, preserving the node's current moderation state.
- [ ] Notify helpdesk via comment on ticket or Slack message in #cms-support that changes are ready for review.
- [ ] Notify helpdesk via comment on ticket or Slack message in #cms-support that changes are ready for review.

#### URL Redirect
| Current URL | Redirect Destination or New URL |
| --- | --- |
| current URL | new URL |

## Use one of the following:
### 1. Canonical URL change or
### 2. Canonical URL removal (if removed from VAST)
### 1. Canonical URL change

**Note: Canonical URL changes do not block the completion of the parent ticket. Once the URL redirect above has been deployed, the value to the Veteran is delivered. This ticket should be kept open until the URL change is verified, except in the case of a removal (as described below).**

### Instructions for canonical URL change
- [ ] Verify that the new URL for the facility is published and accessible on VA.gov.
- [ ] Update the [CSV in Lighthouse](https://github.com/department-of-veterans-affairs/lighthouse-facilities/blob/master/facilities/src/main/resources/websites.csv) with the changed URL, maintaining the sorted order of the Facility API IDs.
- [ ] Create a PR in the [lighthouse-facilities repo](https://github.com/department-of-veterans-affairs/lighthouse-facilities), tagging the Lighthouse team.
- [ ] Post a message in the #cms-lighthouse channel in Slack, with an @mention to a Lighthouse team member.
- [ ] Contact Lighthouse via Slack at #cms-lighthouse channel that this facility requires a canonical link in the following format (replacing the placeholder data with the actual API Id and VA.gov URL):
- `vha_691GM,https://www.va.gov/greater-los-angeles-health-care/locations/oxnard-va-clinic/`
- [ ] Add the "Awaiting CSV" flag to the facility node with a revision log message that includes a link to this ticket.
- [ ] Validate that the change has deployed by checking that the Facility Locator has been updated with the new url.
- [ ] Update this ticket with a comment that the CSV change has been deployed.
- [ ] Remove the "Awaiting CSV" flag to the facility node with a revision log message that includes a link to this ticket.

- [ ] Let Help desk know this has been done, if not done by Help desk.

#### Wait (days or weeks, potentially)
- [ ] After the canonical link has been added to the websites.csv and you have confirmation from Lighthouse that the CSV has been deployed, validate that the change has deployed by checking that the Facility Locator has been updated with the new url.
- [ ] Update this ticket with a comment that the CSV change has been deployed.

#### URL change example (update with actual ID and URL)
| Facility API ID | Full VA.gov URL |
| --- | --- |
| vha_691GM | https://www.va.gov/greater-los-angeles-health-care/locations/oxnard-va-clinic/ |

### 2. Canonical URL removal (if removed from VAST)
### Instructions for canonical URL removal
- [ ] Try to find the facility via the Facility Locator, using the Facility API ID (e.g. https://va.gov/find-locations/facility/"facility_api_id"). If it is not available, proceed.
- [ ] Update the [CSV in Lighthouse](https://github.com/department-of-veterans-affairs/lighthouse-facilities/blob/master/facilities/src/main/resources/websites.csv) removing the row with the Facility API ID.
- [ ] Create a PR in the [lighthouse-facilities repo](https://github.com/department-of-veterans-affairs/lighthouse-facilities), tagging the Lighthouse team.
- [ ] Post a message in the #cms-lighthouse channel in Slack, with an @mention to a Lighthouse team member.
- [ ] Contact Lighthouse via Slack at #cms-lighthouse channel that this facility requires a canonical link to be removed in the following format (replacing the placeholder data with the actual API Id and VA.gov URL):
- `vha_691GM,https://www.va.gov/greater-los-angeles-health-care/locations/oxnard-va-clinic/`

**Note: there's no check to see if it's not returning anything, as it should already be not showing anything in the Facility Locator.**

#### URL removal example (update with actual ID and URL to remove)
Expand Down
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/runbook-vamc-facility-new.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ Please refer to the Knowledge Base article titled "How do I add a facility to my
#### CMS help desk steps
**Note: If the help desk is waiting on information from the facility staff or editor, add the "Awaiting editor" flag to the facility with a log message that includes a link to this ticket. Remove the flag when the ticket is ready to be worked by the Facilities team. Be sure to preserve the current moderation state of the node when adding or removing the flag.**
- [ ] Become aware that the new facility is now on the Facility API (typically, via a Flag, but this may come in as a helpdesk ticket).
- [ ] **If the facility is a VA Mobile clinic, the "New facility" flag can be removed and the page archived with no further work needed. (Note, there are required fields that will need to be filled in before doing so.)**
- [ ] If the editor has followed the steps from the above Knowledge Base article and included which section and VAMC the facility belongs to (i.e. VA Pittsburgh), great!
- If not, please check with the editor or VHA digital media regarding what section and VAMC it belongs to.
- [ ] Update the Section (default is "VAMC facilities", but it should be a VAMC system in a VISN) and VAMC system field accordingly.
Expand Down Expand Up @@ -60,7 +61,6 @@ Please let us know when your draft content is complete, so that we can wrap up t
- [ ] Update the facility **Meta description** field, using the following format: "Get address and hours, parking and transportation information, and health services offered at [facility name]."
- [ ] Move the facility link in the health care system menu to its place in the alphabetized list (medical centers first, then clinics).
- [ ] Drupal Admin bulk publishes nodes and facility.
- [ ] Drupal Admin edit facility node and remove `New facility` flag and save node.
- [ ] Contact Lighthouse via Slack at #cms-lighthouse channel that this facility requires a canonical link in the following format (replacing the placeholder data with the actual API Id and VA.gov URL):
- `vha_691GM,https://www.va.gov/greater-los-angeles-health-care/locations/oxnard-va-clinic/`
- [ ] Add the "Awaiting CSV" flag to the facility node with a revision log message that includes a link to this ticket.
Expand All @@ -69,7 +69,7 @@ Please let us know when your draft content is complete, so that we can wrap up t
#### Wait (days or weeks, potentially)
- [ ] After the canonical link has been added to the websites.csv and you have confirmation from Lighthouse that the CSV has been deployed, validate that the change has deployed by checking that the Facility Locator has been updated with the new url.
- [ ] Update this ticket with a comment that the CSV change has been deployed.
- [ ] Remove the "Awaiting CSV" flag to the facility node with a revision log message that includes a link to this ticket.
- [ ] Edit facility node and remove `New facility` and "Awaiting CSV" flags with a revision log message that includes a link to this ticket.

#### CMS Help desk (wrap up)
- [ ] Notify editor and any other stakeholders.
45 changes: 28 additions & 17 deletions .github/ISSUE_TEMPLATE/runbook-vet-center-new.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ assignees: ''
---

## Description
Use this runbook if: a Vet Centers, Mobile Vet Centers, Vet Center Outstations is flagged as New, OR if an existing facility is flagged as New with a new Facility API ID. (This may happen if a Vet Center moves districts, or a Mobile Vet Center is reallocated to a different Vet Center.)
Use this runbook if: a Vet Center, Mobile Vet Center, or Vet Center Outstation is flagged as New, OR if an existing facility is flagged as New with a new Facility API ID.
- This may also occur when an Outstation is promoted to main Vet Center or if an existing Mobile Vet Center is reallocated to a different Vet Center

## Intake
- [ ] What triggered this runbook? (Flag in CMS, Help desk ticket, Product team, VHA Digital Media)
Expand All @@ -20,7 +21,7 @@ Help desk ticket: <insert_help_desk_link>
- [ ] Name of submitter (if applicable)
Submitter: <insert_name>

- [ ] If the submitter is an editor, send them links to any relevate KB articles for the Vet Center product.
- [ ] If the submitter is an editor, send them links to any relevant KB articles for the Vet Center product.
KB articles: <insert_kb_article_links>

- [ ] Link to facility in production:
Expand All @@ -36,29 +37,39 @@ Facility API ID: <insert_facility_API_ID>
**Note: If the help desk is waiting on information from the facility staff or editor, add the `Awaiting editor` flag to the facility** with a log message that includes a link to this ticket. Remove the flag when the ticket is ready to be worked by the Facilities team. **Be sure to preserve the current moderation state of the node when adding or removing the flag.**

**If a Mobile Vet Center:**
- [ ] Confirm what Vet Center it belongs to, and set the "Main Vet Center location" field. The parent location may be derived by the Facility ID.
- [ ] Confirm the Vet Center to which it belongs and and set the "Main Vet Center location" field. The parent location may be derived by the Facility ID.
- [ ] Follow up with Barb Kuhn/RCS Central office to let her know we've identified this new Mobile unit and confirm the District, Vet Center Director, and Outreach Specialist (names/email addresses) who will be responsible for updates
- [ ] Contact the Vet Center editor to remind them to (1) add a photo of the Mobile Vet Center and then they can publish when ready and (2) remind them that if this Mobile Vet Center is used by any other facilities to communicate with those Vet Center editors
- [ ] Consider: Following up with Barb/RCS Central office to be sure that she's aware that the mobile Vet Center is in-flight

**If a Outstation:**
- [ ] Confirm what Vet Center it belongs to, and set the "Main Vet Center location" field. The parent location may be derived by the Facility ID.
- [ ] Contact the Vet Center editor to remind them to (1) add a photo of the Outstation and then they can publish when ready
- [ ] Consider: Following up with Barb/RCS Central office to be sure that she's aware that the Outstation is in-flight
- [ ] Become aware that the new facility is now on the Facility API (typically, via a Flag).
- [ ] Confirm the Vet Center to which it belongs and set the "Main Vet Center location" field. The parent location may be derived by the Facility ID.
- [ ] Follow up with Barb Kuhn/RCS Central office to let her know we've identified the new Outstation and confirm the District, Vet Center Director, and Outreach Specialist (names/email addresses) who will be responsible for updates
- [ ] Contact the Vet Center editor to remind them to (1) add a photo of the Outstation
- [ ] If the new Outstation replaces a CAP, the editor should consider updating the operating status for the CAP to direct Veterans to the new location with “as of” date and set a reminder on the calendar to archive the CAP 30 days after the new location has opened

**If a Vet Center:**
- [ ] 1. Become aware that the new facility is now on the Facility API (typically, via a Flag).
- [ ] 2. Check with Readjustment Counseling Services to (1) confirm what district the Vet Center belongs and (2) Identify the Vet Center Director and Outreach Specialist (names/email addresses)
- [ ] 3. In [Sections taxonomy](https://prod.cms.va.gov/admin/structure/taxonomy/manage/administration/overview), move the Vet Center Section to the appropriate district.
- [ ] 4. Create accounts (or restrict existing accounts) with editor rights only for Vet Center Director and Outreach Specialist so that they cannot publish on their own.
- [ ] 5. Contact Vet Center Director and Outreach specialist to onboard for training [@TODO write sample email - SEE runbook-vamc-facility-new] **Note: this should include instructions for adding content and preparing for publishing and RCS Central Office should be included as CC**
- [ ] 6. Add flag `Awaiting editor` to this facility. Note: This is now blocked until RCS Central office approves.
- [ ] 7. **Once approved by RCS Central Office as complete, proceed to Drupal Admin publishing steps**
- [ ] Become aware that the new facility is now on the Facility API (typically, via a Flag).
- [ ] Check with Readjustment Counseling Services to (1) confirm what district the Vet Center belongs, (2) identify the Vet Center Director and Outreach Specialist (names/email addresses), (3) confirm the new location isn't a replacement for an existing Outstation
- [ ] In [Sections taxonomy](https://prod.cms.va.gov/admin/structure/taxonomy/manage/administration/overview), move the Vet Center Section to the appropriate district.
- [ ] Create account access as directed by RCS. If editors are new to Drupal, create accounts with editor rights only for Vet Center Director and Outreach Specialist so that they cannot publish on their own.
- [ ] Contact Vet Center Director and Outreach specialist to onboard for training [@TODO write sample email - SEE runbook-vamc-facility-new] **Note: this should include instructions for adding content and preparing for publishing and RCS Central Office should be included as CC**
- [ ] Add flag `Awaiting editor` to this facility. Note: This is now blocked until RCS Central office approves.
- [ ] **Once approved by RCS Central Office as complete, proceed to Drupal Admin publishing steps**


**Drupal Admin steps**
- [ ] 8. Bulk publish the nodes and facility.
- [ ] 9. Edit the facility node: remove the `New facility` and `Awaiting editor` flags, save the node.
- [ ] 10. Let Help desk know this has been done.
- [ ] Bulk publish the nodes and facility.
- [ ] Contact Lighthouse via Slack at #cms-lighthouse channel that this facility requires a canonical link in the following format (replacing the placeholder data with the actual API Id and VA.gov URL):
- `vha_691GM,https://www.va.gov/greater-los-angeles-health-care/locations/oxnard-va-clinic/`
- [ ] Add the "Awaiting CSV" flag to the facility node with a revision log message that includes a link to this ticket.
- [ ] Let Help desk know this has been done, if not done by Help desk.

#### Wait (days or weeks, potentially)
- [ ] After the canonical link has been added to the websites.csv and you have confirmation from Lighthouse that the CSV has been deployed, validate that the change has deployed by checking that the Facility Locator has been updated with the new url.
- [ ] Update this ticket with a comment that the CSV change has been deployed.
- [ ] Edit facility node and remove `New facility` and "Awaiting CSV" flags with a revision log message that includes a link to this ticket.
- [ ] Let Help desk know this has been done, if not done by Help desk.

#### CMS Help desk (wrap up)
- [ ] 11. Upgrade the Vet Center Director and Outreach Specialist accounts to the publisher role for that Vet Center.
Expand Down
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/taxonomy-add-term.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name: "Taxonomy - Add Term"
description: "Use this template when adding terms to the Service or Benefit taxonomy."
title: "[ADD] (Term name) to (taxonomy name)"
labels: Content, Content governance
labels: Content, sitewide

body:

Expand Down Expand Up @@ -90,7 +90,7 @@ body:
- [ ] Term is reviewed by relevant taxonomy governance body
- [ ] Term is either approved for addition, or denied with an explanation
- [ ] If approved, a Drupal admin from Product team may add the term to the taxonomy
- [ ] Content for subfields is drafted in Drupal by Product team
- [ ] Content for subfields is updated in Drupal by Product team
- [ ] (List any necessary review and approval steps here)
- [ ] Term is published
validations:
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/taxonomy-update-term.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name: "Taxonomy - Update Term"
description: "Use this template when updating an existing terms in the Service or Benefit taxonomy."
title: "[UPDATE] (Term name) in (taxonomy name)"
labels: Content, Content governance
labels: Content, sitewide

body:

Expand Down
3 changes: 2 additions & 1 deletion .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ updates:
interval: daily
time: "20:00"
timezone: US/Eastern
open-pull-requests-limit: 10
open-pull-requests-limit: 25
allow:
- dependency-type: direct
ignore:
Expand Down Expand Up @@ -82,3 +82,4 @@ updates:
schedule:
# Check for updates to GitHub Actions every week
interval: "weekly"
open-pull-requests-limit: 10
2 changes: 1 addition & 1 deletion .github/workflows/actions-metrics.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
timeout-minutes: 10
steps:
- name: Send GitHub Actions metrics to DataDog
uses: int128/datadog-actions-metrics@432f143460957c07e730f9f082af7d5063e99f84 # v1.88.0
uses: int128/datadog-actions-metrics@20d0faab9a624fee7b88bea868c4dc04a76b8c67 # v1.90.0
with:
datadog-api-key: ${{ secrets.DATADOG_API_KEY }}
collect-job-metrics: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/contextual-advice.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
# branch or its commits, regardless of provenance.
#
# Do not execute any code located within the repository!
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.sha }}
Expand Down
Loading

0 comments on commit c15b810

Please sign in to comment.