VACMS-17114: Adds logic for getting ALL the phone numbers

docroot/modules/custom/va_gov_post_api/src/Service/PostFacilityServiceVamc.php

@@ -347,39 +347,6 @@ protected function getAppointmentLeadin() {
     return $this->stringNullify($text);
   }
 
-  /**
-   * Get the non-default service location appointment phone type.
-   *
-   * @param string $from_facility
-   *   The value of a single service location's appointment phone type.
-   *
-   * @return string
-   *   The type of service location text that the user chose.
-   */
-  protected function getAppointmentPhoneType($from_facility) {
-    // If the class property's already set to the actionable non-default,
-    // bail out.
-    if (!empty($this->apptPhoneType)) {
-      return $this->apptPhoneType;
-    }
-    $map = [
-      // Value => Return.
-      // Lighthouse decided to receive these as strings since non-bool options.
-      '0' => 'false',
-      '1' => 'true',
-    ];
-    return $map[$from_facility];
-  }
-
-  protected function getAppointmentPhones(array $phone_paragraphs = []) {
-     // If the class property's already set to the actionable non-default,
-     // bail out.
-    if (!empty($this->apptPhones)) {
-      return $this->apptPhones;
-    }
-    return $this->getPhones($this->apptPhoneType, $phone_paragraphs);
-  }
-
   /**
    * Gets the online scheduling value.
    *
@@ -477,9 +444,7 @@ protected function getServiceLocations(): array {
 
         // Set the appointment phone values to the non-default for the service.
         $field_appt_phone_type = $location->get('field_use_facility_phone_number')->value;
-        $this->apptPhoneType = $this->getAppointmentPhoneType($field_appt_phone_type);
-        $this->apptPhones = $this->getAppointmentPhones($location->get('field_other_phone_numbers')->referencedEntities());
-
+        $this->apptPhones[] = $this->getPhones($field_appt_phone_type, $location->get('field_other_phone_numbers')->referencedEntities());
 
         // Set the online scheduling value to yes for the service if so chosen.
         $this->isOnlineSchedulingAvail = ($this->isOnlineSchedulingAvail !== 'false'