Merge branch 'main' into VACMS-15565-reenable_breadcrumb_modules

department-of-veterans-affairs · Oct 10, 2023 · 2eb8a6d · 2eb8a6d
2 parents 7bde831 + 8a8051d
commit 2eb8a6d
Show file tree

Hide file tree

Showing 51 changed files with 1,415 additions and 289 deletions.
diff --git a/.github/ISSUE_TEMPLATE/cms-collaboration-cycle-feedback.md b/.github/ISSUE_TEMPLATE/cms-collaboration-cycle-feedback.md
@@ -0,0 +1,30 @@
+---
+name: CMS Collaboration Cycle Feedback
+about: Use this template for CMS Team practice areas to provide feedback to teams going through the CMS Collaboration Cycle.
+title: 'Name of Collab Touchpoint - Practice Area Feedback - Name of Project'
+labels: CMS Team, CMS-Collab-Cycle, collab-cycle-feedback
+
+---
+
+## VFS actions
+- [ ] Assign this ticket to the team member(s) responsible for addressing feedback provided by the CMS Team.
+- [ ] Comment on this ticket:
+  - [ ] If the CMS Team reviewer has any **Thoughts/Questions** that require responses.
+  - [ ] When **Must** feedback has been incorporated. As appropriate, link to any other GitHub issues or PRs related to this feedback.
+  - [ ] When **Should/Consider** feedback has been incorporated, or if any feedback will not be addressed. As appropriate, link to any other GitHub issues or PRs related to this feedback.
+- [ ] Close the ticket when all feedback has been addressed.
+
+## Thoughts/questions from CMS Team
+- (CMS Team insert thoughts/questions here.)
+
+## Feedback from CMS Team
+The CMS Team practice areas will document their feedback on artifacts provided by VFS teams following the [Must, Should, and Consider Framework](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/must-should-and-consider-framework-for-feedback). CMS Team reviewers may also provide additional notes that don’t comment on the artifacts themselves but are important for implementation (eg. engineering/coding notes or design system feedback).
+
+### Must
+- (CMS Team insert feedback here.)
+
+### Should
+- (CMS Team insert feedback here.)
+
+### Consider
+- (CMS Team insert feedback here.)
diff --git a/.github/ISSUE_TEMPLATE/cms-collaboration-cycle-request.yml b/.github/ISSUE_TEMPLATE/cms-collaboration-cycle-request.yml
@@ -1,6 +1,6 @@
 
 name: CMS Collaboration Cycle Request
-description: Begin engaging with the CMS Collaboration Cycle.
+description: Use this template to begin engaging with the CMS Collaboration Cycle.
 title: "CMS Collaboration Cycle for [Team Name, Product Name, Feature Name]"
 labels: CMS Team, Needs Analysis, CMS-Collab-Cycle, Epic
 assignees:
@@ -11,24 +11,14 @@ body:
   - type: markdown
     attributes:
       value: |
-        Before engaging with the CMS Collaboration Cycle, please fill out the form below to help the CMS Team determine what level of support and which touchpoints are needed for your work.
+        Before engaging with the CMS Collaboration Cycle, please fill out the form below to help the CMS Team determine what level of support and which touchpoints are needed for your work. Have questions about this form? Reach out to the CMS Team in the cms-support Slack channel.
   - type: input
     id: product-outline
     attributes:
       label: Please add a link to your product outline. 
       description: If you have not already made one, you can use this [product outline template](https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/platform/product-management/product-outline-template.md).
     validations:
       required: true
-  - type: checkboxes
-    id: type
-    attributes:
-      label: What type of request are you making?
-      options:
-        - label: Update to an existing CMS feature (including product iterations, updating DS components or page layouts and nav changes)
-        - label: New CMS feature (New content types, DS components, workflows or products)
-        - label: Other (Leave notes in the Additional Information section of this form)
-    validations:
-      required: true
   - type: input
     id: start-date
     attributes:
@@ -41,6 +31,36 @@ body:
       label: When will your product/feature need to launch? 
     validations:
       required: true
+  - type: dropdown
+    id: cms-areas
+    attributes:
+      label:  Select if your work will involve changes to any of the following.
+      multiple: true
+      options:
+        - CMS design system
+        - CMS content model
+        - CMS features that span multiple products or work streams
+        - None of the above
+    validations:
+      required: true
+  - type: dropdown
+    id: request-type
+    attributes:
+      label:  What type of request are you making?
+      multiple: true
+      options:
+        - Update to an existing CMS feature (including product iterations, updating DS components or page layouts and nav changes)
+        - New CMS feature (New content types, DS components, workflows or products)
+        - Other (Leave notes in the Additional Information section of this form)
+    validations:
+      required: true
+  - type: input
+    id: current-implementation
+    attributes:
+      label: Please add a link to the current implementation of this product/feature, if applicable. 
+      description: Only leave this blank if there is nothing that currently exists in the CMS.
+    validations:
+      required: false
   - type: dropdown
     id: research
     attributes:
@@ -49,6 +69,7 @@ body:
       options:
         - "Yes"
         - "No"
+        - "Maybe (Leave notes in the Additional Information section of this form)"
     validations:
       required: true
   - type: dropdown
@@ -59,49 +80,53 @@ body:
       options:
         - "Yes"
         - "No"
+        - "Maybe (Leave notes in the Additional Information section of this form)"
     validations:
       required: true
   - type: dropdown
-    id: analytics
+    id: modules
     attributes:
-      label: Do you need to capture any analytics or metrics?
+      label: Will your work require introducing a new Drupal module or changes to an existing module?
       multiple: false
       options:
         - "Yes"
         - "No"
+        - "Maybe (Leave notes in the Additional Information section of this form)"
     validations:
       required: true
   - type: dropdown
-    id: cms-areas
+    id: analytics
     attributes:
-      label:  Will your work involve changes to...?
-      multiple: true
+      label: Do you need to capture any analytics or metrics?
+      multiple: false
       options:
-        - CMS design system
-        - CMS content model
-        - CMS features that span multiple products or work streams
+        - "Yes"
+        - "No"
+        - "Maybe (Leave notes in the Additional Information section of this form)"
     validations:
       required: true
-  - type: input
-    id: current-implementation
+  - type: dropdown
+    id: KB
     attributes:
-      label: Please add a link to the current implementation of this product/feature, if applicable. 
-      description: Only leave this blank if there is nothing that currently exists in the CMS.
+      label: Will this work require creating/editing any CMS Knowledge Base articles?
+      multiple: false
+      options:
+        - "Yes"
+        - "No"
+        - "Maybe (Leave notes in the Additional Information section of this form)"
     validations:
-      required: false
+      required: true
   - type: textarea
     id: additional-information
     attributes:
       label: Additional Information
       description: Please include any additional information or context that may be relevant to your request.
   - type: checkboxes
-    id: terms
+    id: terms-agreement
     attributes:
-      label:  Please agree to the terms of this form.
-      description: I acknowledge that I must submit this form as an Epic and notify the cms-team user group in the cms-support Slack channel with a link to the epic that is created.
+      label:  I acknowledge that I must submit this form as an Epic and notify the cms-team user group in the cms-support Slack channel with a link to the Epic that is created.
       options:
         - label: I agree.
-    validations:
-      required: true
+          required: true
 
 
diff --git a/.github/workflows/actions-metrics.yml b/.github/workflows/actions-metrics.yml
@@ -11,7 +11,7 @@ jobs:
     timeout-minutes: 10
     steps:
       - name: Send GitHub Actions metrics to DataDog
-        uses: int128/datadog-actions-metrics@c2c3a02962c104c601d6d024405297ffbd80eccf # v1.58.0
+        uses: int128/datadog-actions-metrics@ddee9ed266fc818c601cadbf6a76624c97b61747 # v1.59.0
         with:
           datadog-api-key: ${{ secrets.DATADOG_API_KEY }}
           collect-job-metrics: true

diff --git a/.github/workflows/dependabot-auto-merge.yml b/.github/workflows/dependabot-auto-merge.yml
@@ -31,15 +31,15 @@ jobs:
 
       # Get the initial AWS IAM User credentials. Only has basic permissions for sts:assumeRole
       - name: Configure AWS credentials (1)
-        uses: aws-actions/configure-aws-credentials@8c3f20df09ac63af7b3ae3d7c91f105f857d8497 # v4.0.0
+        uses: aws-actions/configure-aws-credentials@010d0da01d0b5a38af31e9c3470dbfdabdecca3a # v4.0.1
         with:
           aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
           aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
           aws-region: us-gov-west-1
 
       # Get credentials from our SSM role. Least privilege method for AWS IAM.
       - name: Configure AWS Credentials (2)
-        uses: aws-actions/configure-aws-credentials@8c3f20df09ac63af7b3ae3d7c91f105f857d8497 # v4.0.0
+        uses: aws-actions/configure-aws-credentials@010d0da01d0b5a38af31e9c3470dbfdabdecca3a # v4.0.1
         with:
           aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
           aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}

diff --git a/.github/workflows/s3-backup-retention.yml b/.github/workflows/s3-backup-retention.yml
@@ -21,7 +21,7 @@ jobs:
 
       # Get the initial AWS IAM User credentials. Only has basic permissions for sts:assumeRole
       - name: Configure AWS credentials (1)
-        uses: aws-actions/configure-aws-credentials@8c3f20df09ac63af7b3ae3d7c91f105f857d8497 # v4.0.0
+        uses: aws-actions/configure-aws-credentials@010d0da01d0b5a38af31e9c3470dbfdabdecca3a # v4.0.1
         with:
           aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
           aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
@@ -36,7 +36,7 @@ jobs:
 
       # Get credentials from our s3 role. Least privilege method for AWS IAM.
       - name: Configure AWS credentials (1)
-        uses: aws-actions/configure-aws-credentials@8c3f20df09ac63af7b3ae3d7c91f105f857d8497 # v4.0.0
+        uses: aws-actions/configure-aws-credentials@010d0da01d0b5a38af31e9c3470dbfdabdecca3a # v4.0.1
         with:
           aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
           aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}

diff --git a/composer.json b/composer.json
@@ -14,7 +14,6 @@
     },
     "require": {
         "alchemy/zippy": "^1.0.0",
-        "bower-asset/blazy": "^1.8",
         "bower-asset/cropper": "^4.1",
         "caxy/php-htmldiff": "^0.1.14",
         "composer/installers": "^2.2.0",
@@ -31,7 +30,6 @@
         "drupal/animated_gif": "^2.0",
         "drupal/auto_entitylabel": "^3.0",
         "drupal/better_exposed_filters": "^6.0",
-        "drupal/blazy": "^2.0@RC",
         "drupal/block_content_permissions": "^1.6",
         "drupal/cer": "^5.0@beta",
         "drupal/change_labels": "dev-3326097-remove-dependency-on-drupal-autoservices#7f92f90b456ac2f394dd434257e39e1d9b3086eb",
@@ -44,7 +42,7 @@
         "drupal/consumer_image_styles": "^4.0",
         "drupal/consumers": "^1.17.0",
         "drupal/content_lock": "^2.3",
-        "drupal/content_model_documentation": "^1.0@alpha",
+        "drupal/content_model_documentation": "^1.0.19",
         "drupal/core-composer-scaffold": "~9.5.0",
         "drupal/core-recommended": "~9.5.11",
         "drupal/crop": "^2.0",
@@ -102,7 +100,7 @@
         "drupal/jsonapi_resources": "^1.0@beta",
         "drupal/jsonapi_views": "^1.0",
         "drupal/libraries": "^4.0@alpha",
-        "drupal/limited_field_widgets": "^2.0",
+        "drupal/limited_field_widgets": "^2.1@alpha",
         "drupal/linkit": "^6.0@RC",
         "drupal/linky": "^1.0@beta",
         "drupal/linkychecker": "^2.0@beta",
@@ -209,7 +207,7 @@
         "symfony/phpunit-bridge": "^5.1",
         "symfony/process": "^4.0",
         "symfony/routing": "^4.0",
-        "va-gov/content-build": "^0.0.3358",
+        "va-gov/content-build": "^0.0.3361",
         "vlucas/phpdotenv": "^5.3",
         "webflo/drupal-finder": "^1.0.0",
         "webmozart/path-util": "^2.3",