Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Testing GHA CI behaviours #1447

Closed
wants to merge 12 commits into from
Closed

Conversation

JunTaoLuo
Copy link
Contributor

Description

Testing playground for department-of-veterans-affairs/va.gov-cms#13834

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user uid with user_role

  1. Do this
    • Validate that
  2. Then
    • Validate that
  3. Then validate Acceptance Criteria from issue
    • a
    • b
    • c

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@JunTaoLuo JunTaoLuo marked this pull request as draft December 3, 2023 19:42
@JunTaoLuo JunTaoLuo mentioned this pull request Dec 3, 2023
23 tasks
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 4, 2023 20:56 Destroyed
@JunTaoLuo JunTaoLuo force-pushed the jtluo/testing-gha-ci branch from 8811ae1 to cd43388 Compare December 6, 2023 17:59
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 6, 2023 17:59 Destroyed
Copy link

github-actions bot commented Dec 6, 2023

GitHub Workflows (.github/workflows/*.yml)

Have you...

  • pinned all affected GitHub Actions at a specific commit by SHA?
  • reviewed the source code of the action at the commit you are pinning?
  • confirmed that no GitHub security measures are being bypassed?
  • checked for any injection of user content into protected contexts?
  • reviewed Security hardening for GitHub Actions?
  • reviewed GitHub Workflows?

@JunTaoLuo JunTaoLuo closed this Dec 7, 2023
@JunTaoLuo JunTaoLuo deleted the jtluo/testing-gha-ci branch January 3, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants