Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CU] Update yarn and tweak Storybook #97

Merged
merged 13 commits into from
Jan 11, 2024

Conversation

TimRoe
Copy link
Contributor

@TimRoe TimRoe commented Jan 8, 2024

Associated with Ticket 7194 but did not address the goal, just committing useful changes made alongside attempting that.

Description of Change

Changes by proxy to attempting to "Explore Improved Components Package Publish Config" which didn't pan out.

Changes made:

  • Updated yarn from 3.6.1 to 4.0.2
  • Added logic to suppress showing the change background color button that was bugged
    • Added note to ticket 7368 reflecting this change as it'll need to be reverted if/when that is resolved

Testing Packages

Testing

  • Tested on iOS
  • Tested on Android
  • Tested on Web

PR Checklist

Code reviewer validation:

  • General
    • PR is linked to ticket(s)
    • PR has changelog label applied if it's to be included in the changelog
    • Acceptance criteria:
      • All satisfied or
      • Documented reason for not being performed or
      • Split to separate ticket and ticket is linked by relevant AC(s)
    • Above PR sections adequately filled out
    • If any breaking changes, in accordance with the pre-1.0.0 versioning guidelines: a CU ticket has been created for the VA Mobile App detailing necessary adjustments with the package version that will be published by this ticket
  • Code
    • Tests are included if appropriate (or split to separate ticket)
    • New functions have proper TSDoc annotations

Publish

Does not warrant a new version per the versioning guidelines as it is just repo-level and storybook configuration changes; does not alter anything shippable except the packageManager line of the package.json which shouldn't matter.

@TimRoe TimRoe changed the title [Feature] Improve Components Package Structure [CU] Update yarn and tweak Storybook Jan 10, 2024
@TimRoe TimRoe marked this pull request as ready for review January 10, 2024 21:49
@TimRoe TimRoe requested a review from a team as a code owner January 10, 2024 21:49
Copy link
Contributor

@narin narin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just some clarifying questions.

.yarnrc.yml Outdated

yarnPath: .yarn/releases/yarn-3.6.1.cjs
enableGlobalCache: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the benefit of disabling this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea, the changes it made to this file happened automatically when I ran yarn set version 4.0.2.

.yarnrc.yml Outdated
plugins:
- path: .yarn/plugins/@yarnpkg/plugin-workspace-tools.cjs
spec: '@yarnpkg/plugin-workspace-tools'
compressionLevel: mixed
Copy link
Contributor

@narin narin Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we're not using 0 (the default)? Seems to be the fastest according to the docs.

Copy link
Contributor Author

@TimRoe TimRoe Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same logic as above--it set it automatically running the update command. Testing shifting to 0 was fairly slow on a first run (updating every checksum in yarn.lock), but faster on subsequent run.

@TimRoe
Copy link
Contributor Author

TimRoe commented Jan 11, 2024

some clarifying questions

Updated both locally (read: deleted to use the default), will do a quick draft test tomorrow to make sure nothing seems broken and commit if it seems good.

@TimRoe TimRoe merged commit de745ec into main Jan 11, 2024
5 checks passed
@narin narin deleted the feature/7194-roettger-ImproveComponentsPackageStructure branch January 11, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants