-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CU] Update yarn and tweak Storybook #97
[CU] Update yarn and tweak Storybook #97
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just some clarifying questions.
.yarnrc.yml
Outdated
|
||
yarnPath: .yarn/releases/yarn-3.6.1.cjs | ||
enableGlobalCache: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the benefit of disabling this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea, the changes it made to this file happened automatically when I ran yarn set version 4.0.2
.
.yarnrc.yml
Outdated
plugins: | ||
- path: .yarn/plugins/@yarnpkg/plugin-workspace-tools.cjs | ||
spec: '@yarnpkg/plugin-workspace-tools' | ||
compressionLevel: mixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason we're not using 0 (the default)? Seems to be the fastest according to the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same logic as above--it set it automatically running the update command. Testing shifting to 0 was fairly slow on a first run (updating every checksum in yarn.lock
), but faster on subsequent run.
Updated both locally (read: deleted to use the default), will do a quick draft test tomorrow to make sure nothing seems broken and commit if it seems good. |
Associated with Ticket 7194 but did not address the goal, just committing useful changes made alongside attempting that.
Description of Change
Changes by proxy to attempting to "Explore Improved Components Package Publish Config" which didn't pan out.
Changes made:
Testing Packages
Testing
PR Checklist
Code reviewer validation:
changelog
label applied if it's to be included in the changelogPublish
Does not warrant a new version per the versioning guidelines as it is just repo-level and storybook configuration changes; does not alter anything shippable except the
packageManager
line of thepackage.json
which shouldn't matter.