Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tokens] Add new tokens #610

Merged
merged 6 commits into from
Dec 12, 2024
Merged

Conversation

jessicawoodin
Copy link
Contributor

@jessicawoodin jessicawoodin commented Dec 12, 2024

Description of Change

  • Added:
    • border-focus
    • forms-border-success
    • feedback-foreground-info
    • feedback-foreground-error
  • Removed:
    • foreground-error

Testing Packages

Screenshots/Video

Testing

  • Tested on iOS
  • Tested on Android
  • Tested on Web

PR Checklist

Code reviewer validation:

  • General
    • PR is linked to ticket(s)
    • PR has changelog label applied if it's to be included in the changelog
    • Acceptance criteria:
      • All satisfied or
      • Documented reason for not being performed or
      • Split to separate ticket and ticket is linked by relevant AC(s)
    • Above PR sections adequately filled out
    • If any breaking changes, in accordance with the pre-1.0.0 versioning guidelines: a CU ticket has been created for the VA Mobile App detailing necessary adjustments with the package version that will be published by this ticket
  • Code
    • Tests are included if appropriate (or split to separate ticket)
    • New functions have proper TSDoc annotations

Publish

If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:

@jessicawoodin jessicawoodin requested a review from a team as a code owner December 12, 2024 19:34
@@ -151,10 +151,6 @@
"$value": "#e5a000",
"$type": "color"
},
"uswds-system-color-gold-vivid-40": {
Copy link
Contributor

@TimRoe TimRoe Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were removing this and uswds-system-color-green-cool-vivid-30 here and the light figma file intentional or did it happen with timing around Narin's branch being merged?

Edit: If not, think syncing with the synced with main branch locally and running yarn tokens:build then committing should restore them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! It didn't look like that in VS Code, but Narin was just able to help me fix it here. Thanks!

Copy link
Contributor

@TimRoe TimRoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the current state of the branch is undoing Narin's most recent PR in the figma files so there'd be colors missing. See comment for more detail.

@jessicawoodin jessicawoodin requested a review from TimRoe December 12, 2024 21:25
@jessicawoodin jessicawoodin merged commit a99e254 into main Dec 12, 2024
4 of 5 checks passed
@jessicawoodin jessicawoodin deleted the feature/542-jessica-add-color-tokens branch December 12, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants