-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tokens] Add new tokens #610
Conversation
packages/tokens/figma/dark.json
Outdated
@@ -151,10 +151,6 @@ | |||
"$value": "#e5a000", | |||
"$type": "color" | |||
}, | |||
"uswds-system-color-gold-vivid-40": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were removing this and uswds-system-color-green-cool-vivid-30
here and the light figma file intentional or did it happen with timing around Narin's branch being merged?
Edit: If not, think syncing with the synced with main branch locally and running yarn tokens:build
then committing should restore them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! It didn't look like that in VS Code, but Narin was just able to help me fix it here. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the current state of the branch is undoing Narin's most recent PR in the figma files so there'd be colors missing. See comment for more detail.
Description of Change
Testing Packages
Screenshots/Video
Testing
PR Checklist
Code reviewer validation:
changelog
label applied if it's to be included in the changelogPublish
If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:
main
into branchmain