[Bug] Typography – Fix heading bottom margin #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narin
changed the title
TimRoe
reviewed
Dec 10, 2024
| @@ -80,7 +80,7 @@ | |||
| "fontFamily": "{vads-font-family-serif-regular}", | |||
| "fontSize": "{vads-font-size-heading-level-1}", | |||
| "lineHeight": "{vads-font-line-height-heading-2xl}", | |||
| "marginBottom": "{vads-space-3xl}", | |||
| "marginBottom": "{vads-space-lg}", | |||
There was a problem hiding this comment.
Just for personal edification, did this change in Figma? I feel like as part of the initial outlay of the typography tokens (with the base font tokens) these were much larger for the Headings.
There was a problem hiding this comment.
I think they may have but maybe @jessicawoodin can confirm
TimRoe
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
In #550, @jessicawoodin noticed that that bottom spacing for headings was incorrect. This PR updates the values in the
typography.jsontokens to match the Figma values.There will be a follow-up PR (#608) to update the component library to used the updated tokens.
Testing Packages
Screenshots/Video
Testing
PR Checklist
Code reviewer validation:
changeloglabel applied if it's to be included in the changelogPublish
If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:
maininto branchmain