Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tokens] Update components to use tokens package 0.21.0. Update Storybook color docs #605

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

narin
Copy link
Contributor

@narin narin commented Dec 9, 2024

Description of Change

  • Update components to use tokens package 0.21.0.
  • Update storybook color docs to include new color tokens:
    • Primitive
      • uswds-system-color-green-cool-vivid-30
      • uswds-system-color-gold-vivid-40
    • Semantic
      • vads-color-feedback-foregound-success-on-dark: uswds-system-color-green-cool-vivid-30
      • vads-color-feedback-foregound-warning-on-light: uswds-system-color-gold-vivid-40
      • vads-color-feedback-foregound-success-on-light: uswds-system-color-green-cool-vivid-50
      • vads-color-feedback-foregound-warning-on-dark: uswds-system-color-gold-vivid-30

Testing Packages

Screenshots/Video

Screenshot 2024-12-09 at 3 00 01 PM

Testing

  • Tested on iOS
  • Tested on Android
  • Tested on Web

PR Checklist

Code reviewer validation:

  • General
    • PR is linked to ticket(s)
    • PR has changelog label applied if it's to be included in the changelog
    • Acceptance criteria:
      • All satisfied or
      • Documented reason for not being performed or
      • Split to separate ticket and ticket is linked by relevant AC(s)
    • Above PR sections adequately filled out
    • If any breaking changes, in accordance with the pre-1.0.0 versioning guidelines: a CU ticket has been created for the VA Mobile App detailing necessary adjustments with the package version that will be published by this ticket
  • Code
    • Tests are included if appropriate (or split to separate ticket)
    • New functions have proper TSDoc annotations

Publish

If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:

@narin narin requested a review from a team as a code owner December 9, 2024 23:09
/>
</ColorPalette>

### Gold
Copy link
Contributor

@TimRoe TimRoe Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the "Gold" titled ColorItem within "Yellow" ColorPalette above should be pulled down into being paired with this one now that it's here?

Edit:
Or if this should be lumped into the Yellow section instead of having Gold at all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got rid of the Gold section and moved the gold uswds color under Yellow after checking with Jessica.

image

Copy link
Contributor

@TimRoe TimRoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but probably should circle up with Jessica to square away the comment on Yellow/Gold primitive section prior to merging.

@narin narin merged commit d9bc60e into main Dec 13, 2024
4 of 5 checks passed
@narin narin deleted the feature/541-narin-update-to-tokens-0.21.0 branch December 13, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants