-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tokens] Update css-library to 0.16.0 to get feedback tokens #601
Conversation
…partment-of-veterans-affairs/va-mobile-library into feature/1417-narin-update-css-library
/** Remove VADS web font tokens */ | ||
StyleDictionary.registerFilter({ | ||
name: 'filter/fonts/mobile-fonts', | ||
matcher: (token) => token.attributes.category !== 'vads-font', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if there's another way without digging at all, but just noting it feels weird to have a general filter that needs to be applied to all files that didn't previously have a filter to get rid of the vads-font
s.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There doesn't seem to be a way to apply filters to an entire platform or transform group, but style-dictionary 4.0 introduces preprocessors which might be able to clean this up. Created #604 to follow up on it after we update to 4.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving since nothing necessarily needs to change, but have some comments/suggestions.
Also noting it's not linked to a ticket (is it supposed to be just to the same ticket as VADS?).
Description of Change
Updated css-library to 0.16.0 to grab 6 color tokens we had them add:
Primitive
Semantic
Also, VADS web team added their own font tokens in one of the recent versions, some of which conflict with our font tokens. I've added a filter to ignore web font tokens since there is no crossover for fonts between web and mobile.
Testing Packages
Screenshots/Video
Testing
PR Checklist
Code reviewer validation:
changelog
label applied if it's to be included in the changelogPublish
If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:
main
into branchmain