-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Icon – Update "no icon" variant #592
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narin
changed the title
Bug/9064 narin patch icon
[Bug] Icon – Update "no icon" variant
Nov 15, 2024
…veterans-affairs/va-mobile-library into bug/9064-narin-patch-icon
…veterans-affairs/va-mobile-library into bug/9064-narin-patch-icon
…veterans-affairs/va-mobile-library into bug/9064-narin-patch-icon
TimRoe
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR is a follow-up of #573 and a fix for the errors that the app team is running into when running their unit tests:
I initially thought that it might be something related to their jest tsconfig but tried several changes to that without success.
While I do not know the exact reason why the
noIcon
prop is problematic, I confirmed that the errors go away when that type partial is removed. This PR replaces thenoIcon
prop with passing'none'
for name. This required some minor updates to Link and the unit tests as well. Summary of changes:noIcon
prop| 'none'
to name propTesting Packages
Screenshots/Video
iOS
Android
Testing
PR Checklist
Code reviewer validation:
changelog
label applied if it's to be included in the changelogPublish
If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:
main
into branchmain