Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add border tokens to Storybook documentation #547

Merged

Conversation

jessicawoodin
Copy link
Contributor

@jessicawoodin jessicawoodin commented Oct 18, 2024

Description of Change

  • Updated tokens version number in package.json
  • Added border-strong and border-subtle to Storybook documentation

PR Checklist

Code reviewer validation:

  • General
    • PR is linked to ticket(s)
    • PR has changelog label applied if it's to be included in the changelog
    • Acceptance criteria:
      • All satisfied or
      • Documented reason for not being performed or
      • Split to separate ticket and ticket is linked by relevant AC(s)
    • Above PR sections adequately filled out
    • If any breaking changes, in accordance with the pre-1.0.0 versioning guidelines: a CU ticket has been created for the VA Mobile App detailing necessary adjustments with the package version that will be published by this ticket
  • Code
    • Tests are included if appropriate (or split to separate ticket)
    • New functions have proper TSDoc annotations

Publish

Changes do not warrant a new version per the versioning guidelines.

@jessicawoodin jessicawoodin requested a review from a team as a code owner October 18, 2024 19:14
Copy link
Contributor

@narin narin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! For future PRs, please include a screenshot of the changes in the PR description if applicable.

@jessicawoodin jessicawoodin merged commit 8adccb2 into main Oct 21, 2024
5 checks passed
@jessicawoodin jessicawoodin deleted the feature/419-jessica-add-border-tokens-to-storybook branch October 21, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants