Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Bitter Regular font, remove Bitter Bold #544

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

TimRoe
Copy link
Contributor

@TimRoe TimRoe commented Oct 18, 2024

Description of Change

Added Bitter-Regular.ttf (copy from flagship), deleted Bitter-Bold.ttf.

Testing

None, added AC to #495 to update the components package to reflect the changes.

PR Checklist

Code reviewer validation:

  • General
    • PR is linked to ticket(s)
    • PR has changelog label applied if it's to be included in the changelog
    • Acceptance criteria:
      • All satisfied or
      • Documented reason for not being performed or
      • Split to separate ticket and ticket is linked by relevant AC(s)
    • Above PR sections adequately filled out
    • If any breaking changes, in accordance with the pre-1.0.0 versioning guidelines: a CU ticket has been created for the VA Mobile App detailing necessary adjustments with the package version that will be published by this ticket
  • Code
    • Tests are included if appropriate (or split to separate ticket)
    • New functions have proper TSDoc annotations

Publish

If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:

@TimRoe TimRoe marked this pull request as ready for review October 18, 2024 18:29
@TimRoe TimRoe requested a review from a team as a code owner October 18, 2024 18:29
@TimRoe TimRoe merged commit 9a59607 into main Oct 21, 2024
4 of 5 checks passed
@TimRoe TimRoe deleted the feature/538-AddBitterRegular-RemoveBitterBold branch October 21, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants