Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Icon - Enhance Unit Tests #362

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

TimRoe
Copy link
Contributor

@TimRoe TimRoe commented Jun 25, 2024

Description of Change

Added 8 new Icon unit tests around the fill property testing:

  • 4 categories:
    • Single string (does not change with light/dark mode)
    • "default" colors
    • "base" colors
    • Custom light/dark mode color object
  • Light/dark mode for each

Made minor adjustments to existing tests to simplify and/or improve them.

Testing

yarn tests passes with all new Icon tests. Draft tested different expect values caused failures as expected.

PR Checklist

Code reviewer validation:

  • General
    • PR is linked to ticket(s)
    • PR has changelog label applied if it's to be included in the changelog
    • Acceptance criteria:
      • All satisfied or
      • Documented reason for not being performed or
      • Split to separate ticket and ticket is linked by relevant AC(s)
    • Above PR sections adequately filled out
    • If any breaking changes, in accordance with the pre-1.0.0 versioning guidelines: a CU ticket has been created for the VA Mobile App detailing necessary adjustments with the package version that will be published by this ticket
  • Code
    • Tests are included if appropriate (or split to separate ticket)
    • New functions have proper TSDoc annotations

Publish

Changes do not warrant a new version per the versioning guidelines as they are purely unit tests.

@TimRoe TimRoe marked this pull request as ready for review June 25, 2024 20:22
@TimRoe TimRoe requested a review from a team as a code owner June 25, 2024 20:22
@TimRoe TimRoe merged commit c11366f into main Jun 26, 2024
6 of 7 checks passed
@TimRoe TimRoe deleted the tests/223-roettger-EnhanceIconUnitTests branch June 26, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants