Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linting] Add Loading indicator linting rule #356

Merged
merged 4 commits into from
Jun 24, 2024

Conversation

TimRoe
Copy link
Contributor

@TimRoe TimRoe commented Jun 21, 2024

Description of Change

  • Added Loading indicator linting rule to linting package against the LoadingComponent app-level component
  • Bumped linting version to 0.17.1 so it'll align with components' package 0.18.0 for releasing the Loading indicator when publishing in main

Testing Packages

Screenshots/Video

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/components/CommonErrorComponents/CallHelpCenter.tsx
  8:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/components/CommonErrorComponents/DowntimeError.tsx
  6:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/components/CommonErrorComponents/ErrorAlert.tsx
  7:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/components/EncourageUpdate.tsx
  7:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/components/MessageAlert.tsx
  5:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/components/WaygateWrapper.tsx
  8:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/components/WhatsNew.tsx
  7:1  warning  CollapsibleAlert from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/BenefitsScreen/ClaimsScreen/AppealDetailsScreen/AppealDetailsScreen.tsx
  11:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/BenefitsScreen/ClaimsScreen/ClaimDetailsScreen/ClaimDetailsScreen.tsx
  15:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/BenefitsScreen/ClaimsScreen/ClaimDetailsScreen/ClaimStatus/ClaimFileUpload/AskForClaimDecision/AskForClaimDecision.tsx
  9:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/BenefitsScreen/ClaimsScreen/ClaimDetailsScreen/ClaimStatus/ClaimFileUpload/FileRequest.tsx
  11:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/BenefitsScreen/ClaimsScreen/ClaimDetailsScreen/ClaimStatus/ClaimFileUpload/SelectFile/SelectFile.tsx
  10:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/BenefitsScreen/ClaimsScreen/ClaimDetailsScreen/ClaimStatus/ClaimFileUpload/SelectFile/UploadFile/UploadFile.tsx
  11:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/BenefitsScreen/ClaimsScreen/ClaimDetailsScreen/ClaimStatus/ClaimFileUpload/TakePhotos/TakePhotos.tsx
  10:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/BenefitsScreen/ClaimsScreen/ClaimDetailsScreen/ClaimStatus/ClaimFileUpload/TakePhotos/UploadOrAddPhotos/UploadOrAddPhotos.tsx
  14:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead                     deprecate/import
  14:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/BenefitsScreen/ClaimsScreen/ClaimDetailsScreen/ClaimStatus/ClaimTimeline/ClaimTimeline.tsx
  7:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/BenefitsScreen/ClaimsScreen/ClaimDetailsScreen/ClaimStatus/EstimatedDecisionDate/EstimatedDecisionDate.tsx
  7:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/BenefitsScreen/ClaimsScreen/ClaimLettersScreen/ClaimLettersScreen.tsx
  11:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/BenefitsScreen/ClaimsScreen/ClaimsAndAppealsListView/ClaimsAndAppealsListView.tsx
  8:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/BenefitsScreen/ClaimsScreen/ClaimsHistoryScreen/ClaimsHistoryScreen.tsx
  11:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead                     deprecate/import
  11:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/BenefitsScreen/DisabilityRatingsScreen/DisabilityRatingsScreen.tsx
  11:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/BenefitsScreen/Letters/BenefitSummaryServiceVerification/BenefitSummaryServiceVerification.tsx
  11:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/BenefitsScreen/Letters/GenericLetter/GenericLetter.tsx
  10:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead                     deprecate/import
  10:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/BenefitsScreen/Letters/LettersListScreen.tsx
  11:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/Appointments/AppointmentDetailsCommon/AppointmentAlert.tsx
  10:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/Appointments/Appointments.tsx
  13:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/Appointments/PastAppointments/PastAppointments.tsx
  7:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/Appointments/UpcomingAppointments/UpcomingAppointmentDetails.tsx
  17:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/Appointments/UpcomingAppointments/UpcomingAppointments.tsx
  7:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/CernerAlert/CernerAlert.tsx
  8:1  warning  CollapsibleAlert from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/Pharmacy/PrescriptionDetails/PrescriptionDetails.tsx
  12:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/Pharmacy/PrescriptionDetails/PrescriptionsDetailsBanner.tsx
  4:1  warning  CollapsibleAlert from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/Pharmacy/PrescriptionHistory/PrescriptionHistory.tsx
  21:1  warning  CollapsibleAlert from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead             deprecate/import
  21:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/Pharmacy/PrescriptionHistory/PrescriptionHistoryNoPrescriptions.tsx
  4:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/Pharmacy/PrescriptionHistory/PrescriptionHistoryNotAuthorized.tsx
  6:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/Pharmacy/RefillScreens/RefillRequestSummary.tsx
  10:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead                     deprecate/import
  10:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/Pharmacy/RefillScreens/RefillScreen.tsx
  12:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead                     deprecate/import
  12:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/Pharmacy/RefillTrackingDetails/RefillTrackingDetails.tsx
  12:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/SecureMessaging/CernerAlertSM/CernerAlertSM.tsx
  8:1  warning  CollapsibleAlert from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/SecureMessaging/EditDraft/EditDraft.tsx
  32:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead                     deprecate/import
  32:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/SecureMessaging/FolderMessages/FolderMessages.tsx
  12:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/SecureMessaging/Folders/Folders.tsx
  9:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/SecureMessaging/Inbox/Inbox.tsx
  8:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/SecureMessaging/ReplyMessage/ReplyMessage.tsx
  28:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/SecureMessaging/StartNewMessage/Attachments/Attachments.tsx
  12:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/SecureMessaging/StartNewMessage/StartNewMessage.tsx
  26:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead                     deprecate/import
  26:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/SecureMessaging/ViewMessage/CollapsibleMessage.tsx
  9:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/SecureMessaging/ViewMessage/IndividualMessageErrorComponent.tsx
  7:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/SecureMessaging/ViewMessage/MessageCard.tsx
  11:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/SecureMessaging/ViewMessage/ViewMessageScreen.tsx
  24:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead                     deprecate/import
  24:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/Vaccines/NoVaccineRecords/NoVaccineRecords.tsx
  4:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/Vaccines/VaccineDetails/VaccineDetailsScreen.tsx
  9:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HealthScreen/Vaccines/VaccineList/VaccineListScreen.tsx
  9:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HomeScreen/ProfileScreen/ContactInformationScreen/ContactInformationScreen.tsx
  11:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HomeScreen/ProfileScreen/ContactInformationScreen/EditAddressScreen/EditAddressScreen.tsx
  13:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead                     deprecate/import
  13:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HomeScreen/ProfileScreen/ContactInformationScreen/EditEmailScreen/EditEmailScreen.tsx
  11:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead                     deprecate/import
  11:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HomeScreen/ProfileScreen/ContactInformationScreen/EditPhoneNumberScreen/EditPhoneNumberScreen.tsx
  12:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead                     deprecate/import
  12:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HomeScreen/ProfileScreen/MilitaryInformationScreen/MilitaryInformationScreen.tsx
  11:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HomeScreen/ProfileScreen/PersonalInformationScreen/GenderIdentityScreen/GenderIdentityScreen.tsx
  10:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HomeScreen/ProfileScreen/PersonalInformationScreen/PersonalInformationScreen.tsx
  12:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HomeScreen/ProfileScreen/PersonalInformationScreen/PreferredNameScreen/PreferredNameScreen.tsx
  8:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HomeScreen/ProfileScreen/ProfileScreen.tsx
  8:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HomeScreen/ProfileScreen/SettingsScreen/NotificationsSettingsScreen/NotificationsSettingsScreen.tsx
  11:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead                     deprecate/import
  11:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/HomeScreen/ProfileScreen/SettingsScreen/SettingsScreen.tsx
  11:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/PaymentsScreen/DirectDepositScreen/DirectDepositScreen.tsx
  8:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/PaymentsScreen/DirectDepositScreen/EditDirectDepositScreen/EditDirectDepositScreen.tsx
  11:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead                     deprecate/import
  11:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/PaymentsScreen/DirectDepositScreen/HowToUpdateDirectDepositScreen/HowToUpdateDirectDepositScreen.tsx
  6:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/PaymentsScreen/PaymentHistory/NoPayments/NoPaymentsScreen.tsx
  4:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/PaymentsScreen/PaymentHistory/PaymentHistoryScreen.tsx
  10:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/SyncScreen/SyncScreen.tsx
  9:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/WebviewScreen/WebviewScreen.tsx
  8:1  warning  LoadingComponent from components is deprecated. Use LoadingIndicator from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

/Users/timroettger/Coding/VA-Workspace/va-mobile-app/VAMobile/src/screens/auth/LoginScreen/LoginScreen.tsx
  8:1  warning  AlertBox from components is deprecated. Use Alert from @department-of-veterans-affairs/mobile-component-library instead  deprecate/import

✖ 86 problems (0 errors, 86 warnings)

✨  Done in 13.84s.

Testing

  • Verified the linting warnings appeared running yarn lint in the app with alpha package
  • Verified the linting warnings did not appear running yarn lint:ci (so they will not cause build failures)

PR Checklist

Code reviewer validation:

  • General
    • PR is linked to ticket(s)
    • PR has changelog label applied if it's to be included in the changelog
    • Acceptance criteria:
      • All satisfied or
      • Documented reason for not being performed or
      • Split to separate ticket and ticket is linked by relevant AC(s)
    • Above PR sections adequately filled out
    • If any breaking changes, in accordance with the pre-1.0.0 versioning guidelines: a CU ticket has been created for the VA Mobile App detailing necessary adjustments with the package version that will be published by this ticket
  • Code
    • Tests are included if appropriate (or split to separate ticket)
    • New functions have proper TSDoc annotations

Publish

Ticket will publish both a new components and linting package when merged to main to align them on 0.18.0 for Loading indicator "release".

If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:

@TimRoe TimRoe marked this pull request as ready for review June 21, 2024 18:24
@TimRoe TimRoe requested a review from a team as a code owner June 21, 2024 18:24
@TimRoe TimRoe merged commit 7eb56cc into main Jun 24, 2024
9 of 17 checks passed
@TimRoe TimRoe deleted the linting/253-roettger-LoadingIndicatorLintingRule branch June 24, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants