Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Component Implementation - Button #34
[Feature] Component Implementation - Button #34
Changes from 63 commits
bdde4f5
4c5dca3
73615cb
6e4cac8
60208d3
1265e91
4c6cb6a
20e4377
f8e311a
cee8a51
3c414b1
fba51b8
279daaf
96971bf
754f314
1662034
a1cd6ff
83ccad2
9dfcb9d
ea6e190
3534b11
5644693
80aaac4
daaf163
488e51c
92aafe4
dd60e3e
36014a9
69a34b2
2cdfa2c
e3e9f4d
f599981
3aa460d
5bee594
2dcccdd
47d78c5
4b59999
6bac3e2
3718e21
3bdd553
ac99554
b0fd79c
a37d505
a76a7fe
3b9b7b8
d91c2cc
87e8d98
a36f94e
2902e3e
5b9ecde
1dffeeb
d9ec113
39a42a4
5479bb3
41697b2
0efee64
51b03a2
1feef56
76b1a9b
f0b50d1
76e3cee
252de4a
68b132b
747e61c
9f6a783
ce5d3a5
c1ccd01
fe1be63
72ce74c
13fa90c
c78fb9c
e27de2d
3e74b2e
6e53452
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if @jessicawoodin had an in progress ticket where we'd rename the URL to just be
Button
instead ofVAButton
so it matches the component name as well and correspondingly update this reference.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the Storybook is live, I'm going to publish the documentation to a new page called Button in the design system section of the doc site. No need to worry about renaming this here -- it'll be deleted once the new page is live.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicky so don't feel strongly, but if there's a simple way within the Doc section to bump Primary to be at the top instead of Base that would probably make more sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could not figure out a way to sort these properly. According to Storybook docs, they're supposed to be sorted by the way they are written in code but I'm not finding that to be the case. There's ways to set the manually, but we'd have to list out each story in an array which will be a bit cumbersome to do everytime we add a new story.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, initially tried just moving it to the top and was disappointed to see the sort didn't change. Oh well.