Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] SegmentedControl Storybook Updates #25

Merged
merged 7 commits into from
Oct 18, 2023
Merged

[Feature] SegmentedControl Storybook Updates #25

merged 7 commits into from
Oct 18, 2023

Conversation

TimRoe
Copy link
Contributor

@TimRoe TimRoe commented Oct 16, 2023 •
edited
Loading

Originating ticket: 6826

  • Updated the storybook config for Segmented Control to meet design's expectations:
    • More generic "Label #" labels
      • Accordingly updated a11yLabels and a11yHints
    • Added stories for 3 and 4 segments
    • Updated general component explanation doc to match doc site
  • Added support within Web Storybook to be able to easily toggle light/dark mode in the browser to see alternative themed component
    • Only applies to web, mobile devices still rely on the system light/dark toggle

For documentation:

@TimRoe TimRoe marked this pull request as ready for review October 17, 2023 21:15
@TimRoe TimRoe requested a review from a team as a code owner October 17, 2023 21:15
@TimRoe TimRoe merged commit 3cf1551 into main Oct 18, 2023
10 checks passed
@narin narin changed the title 6826 roettger segmented control storybook updates [Feature] SegmentedControl Storybook Updates Nov 28, 2023
@narin narin deleted the 6826-roettger-SegmentedControlStorybookUpdates branch November 30, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narin narin narin approved these changes

@timwright12 timwright12 timwright12 approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimRoe @timwright12 @narin