Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix TS error – Update LinkAnalytics import to relative #209

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

narin
Copy link
Contributor

@narin narin commented Feb 27, 2024

Ticket #170

Description of Change

  • Components integration failed. TypeScript doesn't like the absolute import of Link
  • Updated to use relative import instead

Testing Packages

Screenshots/Video

Testing

  • Tested on iOS
  • Tested on Android
  • Tested on Web

PR Checklist

Code reviewer validation:

  • General
    • PR is linked to ticket(s)
    • PR has changelog label applied if it's to be included in the changelog
    • Acceptance criteria:
      • All satisfied or
      • Documented reason for not being performed or
      • Split to separate ticket and ticket is linked by relevant AC(s)
    • Above PR sections adequately filled out
    • If any breaking changes, in accordance with the pre-1.0.0 versioning guidelines: a CU ticket has been created for the VA Mobile App detailing necessary adjustments with the package version that will be published by this ticket
  • Code
    • Tests are included if appropriate (or split to separate ticket)
    • New functions have proper TSDoc annotations

Publish

If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:

@narin narin requested a review from a team as a code owner February 27, 2024 22:46
@narin narin merged commit 9f1eca0 into main Feb 28, 2024
4 of 6 checks passed
@narin narin deleted the bug/narin-fix-link-ts-error branch February 28, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants