Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CU] Fix semver override #189

Merged
merged 2 commits into from
Feb 16, 2024
Merged

[CU] Fix semver override #189

merged 2 commits into from
Feb 16, 2024

Conversation

narin
Copy link
Contributor

@narin narin commented Feb 16, 2024

Description of Change

Overrides semver to ^7.5.3 in an attempt to resolve dependabot security alert

  • PR [CU] Update dependencies #185 added semver to package.json overrides, but not resolutions
  • This follow-up PR adds semver to resolutions which is Yarn's NPM equivalent to overrides
  • Restested in app to confirm no issues

Testing Packages

  • 0.7.1-alpha.0

Screenshots/Video

iOS

RPReplay_Final1707857477.MP4

Android

screen-20240213-122052.mp4

VA Mobile App

Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2024-02-14.at.13.10.19.mp4

Testing

  • Tested on iOS
  • Tested on Android
  • Tested on Web
  • Tested in VA Mobile App

PR Checklist

Code reviewer validation:

  • General
    • PR is linked to ticket(s)
    • PR has changelog label applied if it's to be included in the changelog
    • Acceptance criteria:
      • All satisfied or
      • Documented reason for not being performed or
      • Split to separate ticket and ticket is linked by relevant AC(s)
    • Above PR sections adequately filled out
    • If any breaking changes, in accordance with the pre-1.0.0 versioning guidelines: a CU ticket has been created for the VA Mobile App detailing necessary adjustments with the package version that will be published by this ticket
  • Code
    • Tests are included if appropriate (or split to separate ticket)
    • New functions have proper TSDoc annotations

Publish

If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:

@narin narin marked this pull request as ready for review February 16, 2024 19:20
@narin narin requested a review from a team as a code owner February 16, 2024 19:20
@narin narin merged commit d13b63a into main Feb 16, 2024
6 of 17 checks passed
@narin narin deleted the cu/142-narin-fix-semver-override branch February 16, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants