-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Update components to use updated color tokens #154
Conversation
@@ -39,7 +39,7 @@ | |||
"homepage": "https://department-of-veterans-affairs.github.io/va-mobile-library", | |||
"dependencies": { | |||
"@department-of-veterans-affairs/mobile-assets": "0.1.1", | |||
"@department-of-veterans-affairs/mobile-tokens": "0.3.1", | |||
"@department-of-veterans-affairs/mobile-tokens": "0.5.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of amused curiosity, what happened with 0.4.0 that was cut a few hours ago and needed bumping again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed 2 colors. Merged missing colors to main
directly by accident. Should have reverted and made a PR but felt the changes were minor enough to let slide. 6de99f9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropping request changes since unit tests also need their import/token calls updated since they're failing. Also one minor typo duplication to clean up.
Ticket #7425
Description of Change
mobile-tokens
package version to 0.5.0 incomponents
's package.jsonTesting Packages
N/A (tested using local workspace reference)
Screenshots/Video
Web (All Button Variants)
Screen.Recording.2024-02-05.at.12.40.05.PM.mov
Web (Segmented Control)
Screen.Recording.2024-02-05.at.12.41.03.PM.mov
iOS (Button Primary Dark/Light Mode)
Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2024-02-05.at.12.45.17.mp4
Android (Button Primary Dark/Light Mode)
Screen_recording_20240205_124805.mp4
Testing
PR Checklist
Code reviewer validation:
changelog
label applied if it's to be included in the changelogPublish
If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:
main
into branchmain