Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update components to use updated color tokens #154

Merged
merged 7 commits into from
Feb 6, 2024

Conversation

narin
Copy link
Contributor

@narin narin commented Jan 29, 2024

Ticket #7425

Description of Change

  • Bumps mobile-tokens package version to 0.5.0 in components's package.json
  • Update Colors design token imports
  • Update color references for both Button and Segmented control
  • Update tests to reference new Colors token

Testing Packages

N/A (tested using local workspace reference)

Screenshots/Video

Web (All Button Variants)

Screen.Recording.2024-02-05.at.12.40.05.PM.mov

Web (Segmented Control)

Screen.Recording.2024-02-05.at.12.41.03.PM.mov

iOS (Button Primary Dark/Light Mode)

Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2024-02-05.at.12.45.17.mp4

Android (Button Primary Dark/Light Mode)

Screen_recording_20240205_124805.mp4

Testing

  • Tested on iOS
  • Tested on Android
  • Tested on Web

PR Checklist

Code reviewer validation:

  • General
    • PR is linked to ticket(s)
    • PR has changelog label applied if it's to be included in the changelog
    • Acceptance criteria:
      • All satisfied or
      • Documented reason for not being performed or
      • Split to separate ticket and ticket is linked by relevant AC(s)
    • Above PR sections adequately filled out
    • If any breaking changes, in accordance with the pre-1.0.0 versioning guidelines: a CU ticket has been created for the VA Mobile App detailing necessary adjustments with the package version that will be published by this ticket
  • Code
    • Tests are included if appropriate (or split to separate ticket)
    • New functions have proper TSDoc annotations

Publish

If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:

@narin narin changed the base branch from main to feature/7425-nr-integrate-vads-uswds-tokens January 29, 2024 18:44
Base automatically changed from feature/7425-nr-integrate-vads-uswds-tokens to main February 5, 2024 17:52
@narin narin added the changelog label Feb 5, 2024
@narin narin marked this pull request as ready for review February 5, 2024 20:54
@narin narin requested a review from a team as a code owner February 5, 2024 20:54
@@ -39,7 +39,7 @@
"homepage": "https://department-of-veterans-affairs.github.io/va-mobile-library",
"dependencies": {
"@department-of-veterans-affairs/mobile-assets": "0.1.1",
"@department-of-veterans-affairs/mobile-tokens": "0.3.1",
"@department-of-veterans-affairs/mobile-tokens": "0.5.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of amused curiosity, what happened with 0.4.0 that was cut a few hours ago and needed bumping again?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed 2 colors. Merged missing colors to main directly by accident. Should have reverted and made a PR but felt the changes were minor enough to let slide. 6de99f9

Copy link
Contributor

@TimRoe TimRoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping request changes since unit tests also need their import/token calls updated since they're failing. Also one minor typo duplication to clean up.

@narin narin requested a review from TimRoe February 5, 2024 22:04
@narin narin merged commit d4fe0d2 into main Feb 6, 2024
6 of 7 checks passed
@narin narin deleted the feature/7425-nr-update-tokens-in-components branch February 6, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants