-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #470 from department-of-veterans-affairs/chore/469…
…-narin-vads-issue-templates Templates for VADS icon and tokens follow up work
- Loading branch information
Showing
2 changed files
with
54 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
--- | ||
name: VADS – Icon update | ||
about: Template for updating our assets package to include new VADS icons | ||
title: DS - VADS icon update: ICON_NAME | ||
labels: ["design-system", "front-end"] | ||
assignees: '' | ||
|
||
--- | ||
## Description | ||
Once VADS has added an icon to their sprite sheet, we need to perform a couple additional steps to extract it and get it added to our assets package. | ||
|
||
- New icons: | ||
- ICON_1 | ||
- ICON_2 | ||
- [Link to VADS PR or Issue]() | ||
|
||
## Acceptance Criteria | ||
<!-- Add a checkbox for each item required to fulfill the user story/issue. --> | ||
|
||
- [ ] Update [component-library](https://www.npmjs.com/package/@department-of-veterans-affairs/component-library) in `assets/package.json` to the latest version | ||
- [ ] Run the [extract-icons](https://github.com/department-of-veterans-affairs/va-mobile-library/blob/main/packages/assets/extract-svgs.js) script to extract the individual SVGs | ||
- [ ] Verify existence of new icon(s) and create a PR to merge to repo | ||
- [ ] Publish a new version of the assets package | ||
- [ ] Update components package to incorporate updated assets package | ||
- [ ] Run [buildIconListFromAssets.js script](https://github.com/department-of-veterans-affairs/va-mobile-library/blob/main/packages/components/buildIconListFromAssets.js) to regenerate assets list | ||
- [ ] Verify new icon(s) available in Storybook | ||
- [ ] [Publish](https://github.com/department-of-veterans-affairs/va-mobile-library/actions/workflows/publish.yml) a new version of the components package | ||
- [ ] Notify @jessicawoodin to add new icons in Figma |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
--- | ||
name: VADS – Tokens update | ||
about: Template for updating our tokens package to include new VADS tokens | ||
title: DS - VADS Token update: TOKENS_DESCRIPTION | ||
labels: ["design-system", "front-end"] | ||
assignees: '' | ||
|
||
--- | ||
## Description | ||
Once VADS has added tokens to their css-library package, we need to perform a couple additional steps to include them in our tokens package. | ||
|
||
- [Link to VADS PR or Issue]() | ||
|
||
## Tokens | ||
- primitive-token-1: VALUE | ||
- semantic-token-1: VALUE | ||
|
||
## Acceptance Criteria | ||
<!-- Add a checkbox for each item required to fulfill the user story/issue. --> | ||
|
||
- [ ] Update [css-library](https://www.npmjs.com/package/@department-of-veterans-affairs/css-library) in `tokens/package.json` to the latest version | ||
- [ ] Run `yarn tokens:build` to rebuild our tokens | ||
- [ ] Check for any errors and verify the addition of the new tokens | ||
- [ ] [Publish](https://github.com/department-of-veterans-affairs/va-mobile-library/actions/workflows/publish.yml) a new version of the tokens package | ||
- [ ] Add new tokens to Storybook | ||
- [ ] Notify @jessicawoodin to add new tokens to Figma |