Skip to content

Commit

Permalink
Fix typo. Add label requirement to PR template
Browse files Browse the repository at this point in the history
  • Loading branch information
narin committed Nov 28, 2023
1 parent 976ebdf commit b7081ad
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
3 changes: 2 additions & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

<!-- Preferred PR naming convention:
'[Issue type] – Brief summary of issue suitable for changelog',
'[Issue type] Copy issue title or brief summary of issue suitable for changelog',
where Issue type = bug, feature, spike, CU (code upkeep), etc.-->

<!-- Preferred branch naming convention:
Expand Down Expand Up @@ -45,6 +45,7 @@ Consider highlighting:
Code reviewer validation:
- General
- [ ] PR is linked to ticket(s)
- [ ] If the PR is unrelated to a specific package, it should be tagged with the 'platform-internal' label (e.g. GitHub Actions work)
- [ ] Acceptance criteria:
- All satisfied _or_
- Documented reason for not being performed _or_
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/tag-internal-pr.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Creates git tag for internal PRs that have been merged and have the
# Creates git tag for PRs that have been merged and have the
# platform-internal label applied in order to keep our changelogs clean
name: Tag internal PR

Expand All @@ -10,15 +10,16 @@ on:
jobs:
tag-internal:
runs-on: ubuntu-latest
name: Tag interal PR
name: Tag internal PR
if: ${{ (github.event.pull_request.merged == true) && (contains(github.event.pull_request.labels.*.name, 'platform-internal')) }}
steps:
- name: Checkout repo
uses: actions/checkout@v4
with:
fetch-depth: 0
token: ${{ secrets.VA_MOBILE_ROBOT_GITHUB_PAT }}
- run: |
- name: Git tag
run: |
CURRENT_DATE=$(date +"%Y-%m-%d-%H%M%S")
TAG=internal-$CURRENT_DATE
Expand Down

0 comments on commit b7081ad

Please sign in to comment.