Kind of works, but env variables don't pass jobs--could convert to GI…

…THUB_OUTPUT
department-of-veterans-affairs · Dec 16, 2023 · 678ba93 · 678ba93
1 parent 12429ef
commit 678ba93
Showing 1 changed file with 1 addition and 26 deletions.
diff --git a/.github/workflows/tokens-build.yml b/.github/workflows/tokens-build.yml
@@ -73,31 +73,6 @@ jobs:
         if: failure() && steps.built.conclusion == 'failure'
         run: |
           echo $BUILD_SUCCESS
-          echo 'BUILD_SUCCESS=false' >> '$GITHUB_ENV'
-          echo $BUILD_SUCCESS
-          echo '{BUILD_SUCCESS}=false' >> '$GITHUB_ENV'
-          echo $BUILD_SUCCESS
-          echo '{BUILD_SUCCESS}={false}' >> '$GITHUB_ENV'
-          echo $BUILD_SUCCESS
-          echo 'env.BUILD_SUCCESS=false' >> '$GITHUB_ENV'
-          echo $BUILD_SUCCESS
-          echo '{env.BUILD_SUCCESS}=false' >> '$GITHUB_ENV'
-          echo $BUILD_SUCCESS
-          echo '{env.BUILD_SUCCESS}={false}' >> '$GITHUB_ENV'
-          echo $BUILD_SUCCESS
-          echo 'BUILD_SUCCESS=false' >> $GITHUB_ENV
-          echo $BUILD_SUCCESS
-          echo '{BUILD_SUCCESS}=false' >> $GITHUB_ENV
-          echo $BUILD_SUCCESS
-          echo '{BUILD_SUCCESS}={false}' >> $GITHUB_ENV
-          echo $BUILD_SUCCESS
-          echo 'env.BUILD_SUCCESS=false' >> $GITHUB_ENV
-          echo $BUILD_SUCCESS
-          echo '{env.BUILD_SUCCESS}=false' >> $GITHUB_ENV
-          echo $BUILD_SUCCESS
-          echo '{env.BUILD_SUCCESS}={false}' >> $GITHUB_ENV
-          echo $BUILD_SUCCESS
-          
 
   tokens-build-success:
     name: Build Process Success/Failure
@@ -114,5 +89,5 @@ jobs:
         if: ${{ env.BUILD_SUCCESS == 'true' }}
         run: echo Great success!
       - name: Tokens Build Failure
-        if: ${{ env.BUILD_SUCCESS == 'false' }}
+        if: success() || ${{ env.BUILD_SUCCESS == 'false' }}
         run: exit 1