Enhance component styling and parameters

- Removed TODO comments in Button and SegmentedControl components to clean up the codebase. - Updated Link component to set marginBottom to 0
department-of-veterans-affairs · Dec 13, 2024 · 5402a2d · 5402a2d
1 parent 87fa448
commit 5402a2d
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 2 deletions.
diff --git a/packages/components/.storybook/web/preview.tsx b/packages/components/.storybook/web/preview.tsx
@@ -5,6 +5,9 @@ import { useDarkMode } from 'storybook-dark-mode'
 
 export const parameters = {
   actions: { argTypesRegex: '^on[A-Z].*' },
+  viewport: {
+    defaultViewport: 'mobile2',
+  },
   controls: {
     matchers: {
       color: /(background|color)$/i,

diff --git a/packages/components/src/components/Button/Button.tsx b/packages/components/src/components/Button/Button.tsx
@@ -116,7 +116,6 @@ export const Button: React.FC<ButtonProps> = ({
    * @returns TextStyle for text
    */
   const getTextStyle = (pressed: boolean): TextStyle => {
-    // TODO: Replace with typography tokens
     const font: TextStyle = {
       ...typography.vadsFontBodyLarge,
       fontFamily: family.vadsFontFamilySansSerifBold,

diff --git a/packages/components/src/components/Link/Link.tsx b/packages/components/src/components/Link/Link.tsx
@@ -156,6 +156,7 @@ export const Link: FC<LinkProps> = ({
 
   const textStyle: TextStyle = {
     ...typography.vadsFontBodyLarge,
+    marginBottom: 0,
     color: linkColor,
     textDecorationColor: linkColor,
     textDecorationLine: 'underline',

diff --git a/packages/components/src/components/SegmentedControl/SegmentedControl.tsx b/packages/components/src/components/SegmentedControl/SegmentedControl.tsx
@@ -90,7 +90,6 @@ export const SegmentedControl: FC<SegmentedControlProps> = ({
       total: labels.length,
     })
 
-    // TODO: Replace with typography tokens
     const textStyle: TextStyle = {
       ...typography.vadsFontBodyLarge,
       fontFamily: isSelected ? 'SourceSansPro-Bold' : 'SourceSansPro-Regular',