Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/10354 - In-App Feedback: Phone number, SSN, Email are not properly recognized if they end in punctuation #10395

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

matt-guest-wilcore
Copy link
Contributor

Description of Change

Ticket

The in-app feedback screen doesn't allow for personal information such as phone numbers, SSN and emails, if they are detected then we must show the user a warning.

As described in the ticket, if someone input an email but ended it with punctuation then we wouldn't show the user the warning.

This PR fixes that issue, we can now detect sensitive information even if it has punctuation.

Screenshots/Video

Testing

Navigate to the developer screen to find the in-app feedback screen

  • Tested on iOS
  • Tested on Android

Reviewer Validations

Verify that sensitive information like emails, phone numbers and SSNs that end in punctuation trigger a warning alert.

EX:

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant