Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/9661-Chika-AddDODToProofOfVeteranStatus #10266

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

cadibemma
Copy link
Contributor

Description of Change

  • The goal of this ticket is to add a new section to the Proof of Veteran Status page in the mobile app. To meet legislative requirements and to be in parity with the va.gov experience, users' unique DoD ID number needs to be added.

Screenshots/Video

Before:

After: (User with ID / User without ID)

  

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

  • Veteran's DoD ID number is added to the Proof of Veteran Status page as shown in the Figma design
  • If a user does not have a DoD ID (null value), the section should be removed entirely from the Proof of Veteran Status page
  • Update demo mode to reflect this change

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@dumathane dumathane added FE-With QA A PR waiting for QA Activity and removed FE-Needs Review labels Dec 3, 2024
@github-actions github-actions bot added FE-Ready to Merge and removed FE-With QA A PR waiting for QA Activity labels Dec 3, 2024
@cadibemma cadibemma merged commit a940b78 into develop Dec 3, 2024
43 of 44 checks passed
@cadibemma cadibemma deleted the 9661-add-dod-to-proof-of-vs branch December 3, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants