Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/10058-rachael-detox-messages-AF-failing #10263

Merged
merged 7 commits into from
Dec 4, 2024

Conversation

rbontrager
Copy link
Contributor

@rbontrager rbontrager commented Nov 25, 2024

Description of Change

Detox is being detox again and we have some weird failures that are only a problem in github actions and only happen occasionally. Fixed it by removing WG_StartNewMessage' and 'WG_ReplyMessage' options when running 'verify AF use case 2 Update available'

Passing android test (has the bug where it still shows a failed even if retest passed) here

Screenshots/Video

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@rbontrager rbontrager marked this pull request as ready for review December 3, 2024 19:18
@rbontrager rbontrager requested review from a team as code owners December 3, 2024 19:18
@rbontrager rbontrager merged commit b7c8156 into develop Dec 4, 2024
26 of 28 checks passed
@rbontrager rbontrager deleted the bug/10058-rachael-detox-messages-AF-failing branch December 4, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants