Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU/9955-rachael-detox-add-comments-to-utils #10260

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

rbontrager
Copy link
Contributor

Description of Change

Add comments to the functions that did not already have them in utils. Cleaned up the rest of the comments so they were all uniformed. Removed a non-used part of a function in home screen.

Screenshots/Video

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@@ -605,6 +625,11 @@ const navigateToFeature = async (featureNavigationArray) => {
}
}

/** Disables the availibility banner.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/** Runs a test to verify the availability banner for a given feature

@rbontrager rbontrager requested a review from TKDickson December 2, 2024 14:14
@rbontrager rbontrager merged commit f321992 into develop Dec 2, 2024
16 of 17 checks passed
@rbontrager rbontrager deleted the CU/9955-rachael-detox-add-comments-to-utils branch December 2, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants