Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/Binny-10233-CreatePIIFilter #10237

Merged
merged 5 commits into from
Dec 3, 2024
Merged

feature/Binny-10233-CreatePIIFilter #10237

merged 5 commits into from
Dec 3, 2024

Conversation

dumathane
Copy link
Contributor

@dumathane dumathane commented Nov 21, 2024 •
edited
Loading

Description of Change

Screenshots/Video

      

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@dumathane dumathane requested review from a team as code owners November 21, 2024 18:05
@github-actions github-actions bot added the FE-Changes Requested Requested changes from Eng or QA label Nov 21, 2024
@dumathane dumathane requested a review from Sparowhawk November 25, 2024 15:59
@dumathane dumathane added FE-Needs Review and removed FE-Changes Requested Requested changes from Eng or QA labels Nov 25, 2024
cadibemma
cadibemma previously approved these changes Nov 25, 2024
View reviewed changes
@github-actions github-actions bot added the FE-With QA A PR waiting for QA Activity label Nov 25, 2024
@github-actions github-actions bot added FE-Ready to Merge and removed FE-With QA A PR waiting for QA Activity labels Dec 2, 2024
@dumathane dumathane merged commit 70f7ba1 into develop Dec 3, 2024
87 of 89 checks passed
@dumathane dumathane deleted the feature/Binny-10233-CreatePIIFilter branch December 3, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cadibemma cadibemma cadibemma approved these changes

@rbontrager rbontrager rbontrager approved these changes

@timwright12 timwright12 Awaiting requested review from timwright12 timwright12 is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@alexandec alexandec Awaiting requested review from alexandec alexandec is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@theodur theodur Awaiting requested review from theodur theodur is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@DonMcCaugheyUSDS DonMcCaugheyUSDS Awaiting requested review from DonMcCaugheyUSDS DonMcCaugheyUSDS is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@Sparowhawk Sparowhawk Awaiting requested review from Sparowhawk

Assignees
No one assigned
Labels
FE-Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dumathane @rbontrager @cadibemma @Sparowhawk