Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/9615-BiometricLoginRefreshTokenFix #10040

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

Sparowhawk
Copy link
Contributor

Description of Change

Set the storage to AES for the keychain token. AES and FB according to this thread
oblador/react-native-keychain#262

Does not throw this error Wrapped error: javax.crypto.IllegalBlockSizeException which seems to be the bulk of the spike

Biometric when not specified seems to pick one based on the library settings, which I haven't been able to determine what the default is, but is likely RSA or KC which both cause this issue

Screenshots/Video

N/A

Testing

Yarn test

  • Tested on iOS
  • Tested on Android

Reviewer Validations

Biometrics should work and not kick you back out of the app and force you to log back in to use biometrics

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@Sparowhawk Sparowhawk requested review from a team as code owners October 25, 2024 19:21
@Sparowhawk Sparowhawk changed the title set storage to AES bug/9615-BiometricLoginRefreshTokenFix Oct 25, 2024
Copy link
Contributor

@dumathane dumathane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests still failing.

@github-actions github-actions bot added the FE-Changes Requested Requested changes from Eng or QA label Oct 29, 2024
@Sparowhawk Sparowhawk requested a review from dumathane October 29, 2024 16:18
@Sparowhawk
Copy link
Contributor Author

@dumathane updated unit tests

@Sparowhawk Sparowhawk removed the FE-Changes Requested Requested changes from Eng or QA label Oct 29, 2024
dumathane
dumathane previously approved these changes Nov 12, 2024
@github-actions github-actions bot added the FE-With QA A PR waiting for QA Activity label Nov 12, 2024
@Sparowhawk Sparowhawk requested a review from dumathane November 14, 2024 17:48
@rbontrager rbontrager removed the FE-With QA A PR waiting for QA Activity label Nov 15, 2024
@dumathane dumathane added the blocked Ticket is blocked and can't be worked at this time label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Ticket is blocked and can't be worked at this time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants