-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug/9615-BiometricLoginRefreshTokenFix #10040
Open
Sparowhawk
wants to merge
15
commits into
develop
Choose a base branch
from
bug/9615-BiometricLoginRefreshTokenFix
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sparowhawk
requested review from
timwright12,
alexandec,
theodur,
dumathane,
cadibemma and
DonMcCaugheyUSDS
October 25, 2024 19:21
dumathane
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests still failing.
github-actions
bot
added
the
FE-Changes Requested
Requested changes from Eng or QA
label
Oct 29, 2024
@dumathane updated unit tests |
dumathane
previously approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Set the storage to AES for the keychain token. AES and FB according to this thread
oblador/react-native-keychain#262
Does not throw this error Wrapped error: javax.crypto.IllegalBlockSizeException which seems to be the bulk of the spike
Biometric when not specified seems to pick one based on the library settings, which I haven't been able to determine what the default is, but is likely RSA or KC which both cause this issue
Screenshots/Video
N/A
Testing
Yarn test
Reviewer Validations
Biometrics should work and not kick you back out of the app and force you to log back in to use biometrics
PR Checklist
Reviewer: Confirm the items below as you review
For QA
Run a build for this branch