Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#20 Add v3 Notification Route Handler #31

Merged
merged 17 commits into from
Sep 6, 2024

Conversation

k-macmillan
Copy link
Member

@k-macmillan k-macmillan commented Sep 5, 2024

Description

Added the v3 notification route and route handler, as well as tests.

Updated pyproject.toml, dependencies, pre-commit, and the github action to run tests as well.

issue #20

How Has This Been Tested?

TDD. Unit tests were made and code was added/updated until tests passed.
image

Can be ran locally with fastapi dev app/main.py You can then exercise the endpoints through the docs.
image

Server throwing a 500 with the curl request:
image

And what it looks like on the server:
image

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works. Testing guidelines
  • I have ensured the latest main is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket was moved into the DEV test column when I began testing this change

@k-macmillan k-macmillan added the enhancement New feature or request label Sep 5, 2024
@k-macmillan k-macmillan self-assigned this Sep 5, 2024
@k-macmillan k-macmillan marked this pull request as ready for review September 5, 2024 19:48
@k-macmillan k-macmillan requested a review from a team September 5, 2024 20:25
cris-oddball
cris-oddball previously approved these changes Sep 5, 2024
Copy link
Contributor

@cris-oddball cris-oddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k-macmillan k-macmillan requested a review from a team September 5, 2024 20:33
@k-macmillan k-macmillan merged commit 63f87dc into main Sep 6, 2024
3 checks passed
@k-macmillan k-macmillan deleted the 20-notification-route-handler branch December 23, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants