forked from cds-snc/notification-utils
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#169 Upgrade Mistune to v3 #187
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the formatter tests. 82 failures now.
kalbfled
commented
Dec 17, 2024
@@ -49,6 +43,17 @@ | |||
)) | |||
|
|||
|
|||
def compose1(value, *fs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This replaces the "take" functionality.
kalbfled
added
dependencies
Pull requests that update a dependency file
internal
labels
Dec 17, 2024
… lists to display as ordered; added more tests
mchlwellman
approved these changes
Dec 18, 2024
ChrisJohnson-CDJ
approved these changes
Dec 18, 2024
EvanParish
approved these changes
Dec 18, 2024
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes upgrade Mistune to v3.0.2, simplify the class inheritance structure, remove unused code, implement new unit tests, and bump the minor version number. Please begin by reading this comment that summarizes the task at a high level.
This comment summarizes the changes I made to the class structures.
issue #169
How Has This Been Tested?
I created an API branch that includes the changes on this Utils branch.
The API sends e-mail with both the html and plain text body (see here), and the mail client displays one. You can toggle which one in a client. You can also "view source" for the message, copy the base64 encoded html or plain text body, and view it decoded on a site like base64decode.
There is a template that contains every markdown element. We used this template for our test e-mails.
HTML with my changes looks identical to Prod
Plain text with my changes looks identical to Prod
"Bulletted list" content with my changes looks identical to Prod
Checklist