Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#163 Update dependencies and Github templates. #172

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

kalbfled
Copy link
Member

@kalbfled kalbfled commented Sep 6, 2024

Description

I upgraded the pyyaml package and the testing packages of note to Dependabot. Among the files in setup.py, only pyyaml and mistune are pinned to specific versions, and we are not updating mistune.

I also updated Github templates consistent with the changes made for other repositories.

issue #163

Type of change

Please check the relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • Hotfix (quick fix for an urgent bug or issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation changes only

How Has This Been Tested?

  • All unit tests pass (I ran pip install -U <package> locally before running the tests as prescribed in the readme.)
  • Regression tests pass

I deployed an API branch that uses this Utils branch and observed that regression tests pass. See here.

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works. Testing guidelines
  • I have ensured the latest main is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket is now moved into the DEV test column
  • I have added a bullet for this work to the Engineering Key Wins slide for review

@kalbfled kalbfled self-assigned this Sep 6, 2024
@kalbfled kalbfled marked this pull request as ready for review September 9, 2024 20:08
@kalbfled kalbfled merged commit 979cbb6 into main Sep 9, 2024
4 checks passed
@kalbfled kalbfled deleted the 163-upgrades branch December 2, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants