Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#127 Bugfix: Email Preview Exposes HTML Tags #171

Merged
merged 9 commits into from
Aug 27, 2024

Conversation

EvanParish
Copy link

@EvanParish EvanParish commented Aug 22, 2024

Description

This PR fixes the bug with email previews exposing html tags when they include personalizations.

issue #127

Type of change

Please check the relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • Hotfix (quick fix for an urgent bug or issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation changes only

How Has This Been Tested?

  • Added unit tests
  • All existing tests pass
  • Deployed to Dev and verified fix in Portal
  • Deployed to Dev and verified fix using preview endpoints

Using this email template:
68747470733a2f2f6170692e7a656e6875622e636f6d2f617474616368656446696c65732f65794a66636d467062484d694f6e73696257567a6332466e5a534936496b4a42614842424d6b6445516d633950534973496d563463434936626e5673624377696348567

We get this in preview mode now:
68747470733a2f2f6170692e7a656e6875622e636f6d2f617474616368656446696c65732f65794a66636d467062484d694f6e73696257567a6332466e5a534936496b4a42614842424d6b744b516d633950534973496d563463434936626e5673624377696348567

Sending the test email is also properly formatted:
361575709-dd1d8c89-4a94-4ee1-acc4-ba654f0bbc39

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works. Testing guidelines
  • I have ensured the latest main is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket is now moved into the DEV test column
  • I have added a bullet for this work to the Engineering Key Wins slide for review

@EvanParish EvanParish added the bug Something isn't working label Aug 22, 2024
@EvanParish EvanParish self-assigned this Aug 22, 2024
@EvanParish EvanParish linked an issue Aug 22, 2024 that may be closed by this pull request
2 tasks
@EvanParish EvanParish marked this pull request as ready for review August 26, 2024 20:54
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new test! I hope you wrote the test before the implementation. 😉

@EvanParish EvanParish merged commit 170bfbf into main Aug 27, 2024
4 checks passed
@EvanParish EvanParish changed the title #127 Bugfix: Email Preview Exposed HTML Tags #127 Bugfix: Email Preview Exposes HTML Tags Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Email Preview Exposed HTML Tags - Personalisations within Hyperlinks
3 participants