Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2163 HOTFIX - Status Reason Updates #2196

Merged
merged 3 commits into from
Dec 19, 2024
Merged

#2163 HOTFIX - Status Reason Updates #2196

merged 3 commits into from
Dec 19, 2024

Conversation

EvanParish
Copy link

@EvanParish EvanParish commented Dec 19, 2024

Description

This updates a couple of the status reasons that needed to change to be in line with the ADR. It also updates the logic blocking updates from happening to notifications that would have been updated with a "bounce" status reason.

issue #2163

How Has This Been Tested?

  • unit tests updated
  • deployed to Dev and regression passed

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works. Testing guidelines
  • I have ensured the latest main is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket was moved into the DEV test column when I began testing this change

@EvanParish EvanParish self-assigned this Dec 19, 2024
@EvanParish EvanParish marked this pull request as ready for review December 19, 2024 21:55
@EvanParish EvanParish requested a review from a team as a code owner December 19, 2024 21:55
@cris-oddball cris-oddball changed the title HOTFIX - Status Reason Updates #2163 HOTFIX - Status Reason Updates Dec 19, 2024
@EvanParish EvanParish merged commit 9a2a4b4 into main Dec 19, 2024
13 checks passed
@EvanParish EvanParish deleted the HOTFIX-status-reasons branch December 19, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants