Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1357 - Redact personalization in POST responses #2185

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

mchlwellman
Copy link

@mchlwellman mchlwellman commented Dec 16, 2024

Description

This PR redacts personalization in POST responses to /v2/notifications, a follow up to this PR.

issue #1357

How Has This Been Tested?

Screenshot 2024-12-16 at 1 20 41 PM

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works. Testing guidelines
  • I have ensured the latest main is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket was moved into the DEV test column when I began testing this change

@mchlwellman mchlwellman self-assigned this Dec 16, 2024
@mchlwellman mchlwellman marked this pull request as ready for review December 16, 2024 18:27
@mchlwellman mchlwellman requested a review from a team as a code owner December 16, 2024 18:27
@cris-oddball cris-oddball changed the title #1357 Redact personalization in POST responses. #1357 - Redact personalization in POST responses Dec 16, 2024
@mchlwellman mchlwellman merged commit 3ea6227 into main Dec 16, 2024
13 checks passed
@mchlwellman mchlwellman deleted the 1357-redact-personalisation-post branch December 16, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants