Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2174 HOTFIX - Fix dependency ticket cron to run every week #2173

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

coreycarvalho
Copy link

@coreycarvalho coreycarvalho commented Dec 10, 2024

Description

The cron implementation was set to run only on Monday's that were also the 14th day of the month 🤦 . This hotfix makes the cron run every week on a Monday regardless of the date. Github Actions does not have a native way to specify every 2 weeks with cron, and since we check if a ticket is already created before creating a new one, I'm comfortable having this run once per week.

Issue #2174

How Has This Been Tested?

The ticket creation portion works, but the cron was set to a schedule that would likely never run. We will have to wait until next Monday to make sure it kicks off.

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works. Testing guidelines
  • I have ensured the latest main is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket was moved into the DEV test column when I began testing this change

@coreycarvalho coreycarvalho self-assigned this Dec 10, 2024
@coreycarvalho coreycarvalho changed the title Fix dependency ticket cron to run every week HOTFIX - Fix dependency ticket cron to run every week Dec 10, 2024
@coreycarvalho coreycarvalho marked this pull request as ready for review December 10, 2024 20:06
@coreycarvalho coreycarvalho requested a review from a team as a code owner December 10, 2024 20:06
Copy link

@MackHalliday MackHalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

Copy link

@EvanParish EvanParish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the cron here. Looks good to me.

@coreycarvalho coreycarvalho merged commit d78a365 into main Dec 10, 2024
13 checks passed
@coreycarvalho coreycarvalho deleted the HOTFIX-dependency-ticket branch December 10, 2024 20:31
@cris-oddball cris-oddball changed the title HOTFIX - Fix dependency ticket cron to run every week #2174 HOTFIX - Fix dependency ticket cron to run every week Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants