Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2166 - Update Delivery Status Lambda SSM Processing #2167

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

k-macmillan
Copy link
Member

@k-macmillan k-macmillan commented Dec 6, 2024

Description

We saw a bunch of 403s from our delivery status lambda. That was because we allowed the auth param to be set to None. This PR fixes that.

Had to add two # nosec lines due to Bandit thinking those were secrets.

issue #2166

How Has This Been Tested?

Deployed. Used this test body in the lambda console and got an "Authenticated Twilio request" log statement. DD logs.

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works. Testing guidelines
  • I have ensured the latest main is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket was moved into the DEV test column when I began testing this change

@k-macmillan k-macmillan self-assigned this Dec 6, 2024
@k-macmillan k-macmillan marked this pull request as ready for review December 6, 2024 14:51
@k-macmillan k-macmillan requested a review from a team as a code owner December 6, 2024 14:51
Copy link

@MackHalliday MackHalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@k-macmillan k-macmillan merged commit c746363 into main Dec 6, 2024
13 checks passed
@k-macmillan k-macmillan deleted the 2166-delivery-status-lambda-ssm-fix branch December 6, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants