Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2157 - Updated Github Action runs-on #2158

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

k-macmillan
Copy link
Member

@k-macmillan k-macmillan commented Dec 4, 2024

Description

Modified runs-on to use a plaintext repo variable so we can set it once, everywhere. Easy to update whenever we need. After verifying 24.04 works we can change it to ubuntu-latest for all.

issue #2157

How Has This Been Tested?

Pushed then kicked off a Deploy Lambdas to Env Action to verify it grabbed the variable and used it properly.

Deployed with the updated action:
image

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works. Testing guidelines
  • I have ensured the latest main is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket was moved into the DEV test column when I began testing this change

@k-macmillan k-macmillan self-assigned this Dec 4, 2024
@k-macmillan k-macmillan marked this pull request as ready for review December 4, 2024 19:18
@k-macmillan k-macmillan requested a review from a team as a code owner December 4, 2024 19:18
@k-macmillan k-macmillan merged commit b6bc1e9 into main Dec 4, 2024
4 of 5 checks passed
@k-macmillan k-macmillan deleted the 2157-update-actions-runs-on branch December 4, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants