Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1972 - Automate release note posting to Oddball Slack #2098

Merged
merged 4 commits into from
Nov 4, 2024
Merged

#1972 - Automate release note posting to Oddball Slack #2098

merged 4 commits into from
Nov 4, 2024

Conversation

coreycarvalho
Copy link

@coreycarvalho coreycarvalho commented Nov 4, 2024 •
edited
Loading

Description

This PR automates the posting of release notes to Oddball's Slack workspace.

issue #1972

How Has This Been Tested?

Tested posting to Slack here:
image

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works. Testing guidelines
  • I have ensured the latest main is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket was moved into the DEV test column when I began testing this change

@coreycarvalho coreycarvalho force-pushed the 1972-automated-slack-posting branch from 1936f86 to 7c368ec Compare November 4, 2024 14:46
@coreycarvalho coreycarvalho self-assigned this Nov 4, 2024
@coreycarvalho coreycarvalho changed the title Testing release posting automation Automate release note posting to Oddball Slack Nov 4, 2024
@coreycarvalho coreycarvalho changed the title Automate release note posting to Oddball Slack #1972 - Automate release note posting to Oddball Slack Nov 4, 2024
@coreycarvalho coreycarvalho marked this pull request as ready for review November 4, 2024 14:50
@coreycarvalho coreycarvalho requested a review from a team as a code owner November 4, 2024 14:50
cris-oddball
cris-oddball approved these changes Nov 4, 2024
View reviewed changes
Copy link

@cris-oddball cris-oddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conditional approval, noting that we will need to copy/paste these notes to the DSVA Slack until we get an app from them.

@coreycarvalho coreycarvalho merged commit a352af6 into main Nov 4, 2024
13 checks passed
@coreycarvalho coreycarvalho deleted the 1972-automated-slack-posting branch November 4, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cris-oddball cris-oddball cris-oddball approved these changes

@k-macmillan k-macmillan k-macmillan approved these changes

Assignees

@coreycarvalho coreycarvalho

Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coreycarvalho @k-macmillan @cris-oddball